Differential D9653

Move inclusion of opt_printf.h around so that we can compile all the SCSI modules outside of a sub-build from the kernel.
ClosedPublic
Actions

Authored by imp on Feb 17 2017, 5:59 PM.

Details

Reviewers

scottl

Group Reviewers

cam

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7536
Build 7690: arc lint + arc unit

Event Timeline

imp updated this revision to Diff 25320.Feb 17 2017, 5:59 PM

imp retitled this revision from to Move inclusion of opt_printf.h around so that we can compile all the SCSI modules outside of a sub-build from the kernel..

imp updated this object.

imp edited the test plan for this revision. (Show Details)

imp added a reviewer: scottl.

imp added inline comments.Feb 17 2017, 6:04 PM

sys/cam/cam_xpt.h
37	It turns out that including this in cam_xpt.h means that every single module that includes cam_xpt.h needs to have opt_printf.h in their Makefile, or it won't compile.
58–66	This is just used in cam_xpt.c, so belongs there, especially since having it in the .h causes dependency issues.

Seems sensible.

sys/conf/config.mk
30	Maybe don't set this? The CAM code will be the same as it already assumes a default of 128 if PRINT_BUFR_SIZE isnt' set.

imp added inline comments.Feb 18 2017, 6:16 PM

sys/conf/config.mk
30	Hmmm, I'm torn between that and removing the fallback in the CAM code... I do know that Scott has some other work in progress, though, that I need to wait to land before I polish this too much.