Differential D8549

Port the Linux AMD xgbe driver to FreeBSD as axgbe
ClosedPublic
Actions

Authored by andrew on Nov 17 2016, 5:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 4:45 PM

	Unknown Object (File)
	Mon, Jan 27, 4:05 PM

	Unknown Object (File)
	Mon, Jan 27, 3:47 PM

	Unknown Object (File)
	Sun, Jan 19, 2:38 AM

	Unknown Object (File)
	Jan 2 2025, 7:15 PM

	Unknown Object (File)
	Dec 5 2024, 2:08 AM

	Unknown Object (File)
	Nov 19 2024, 2:10 PM

	Unknown Object (File)
	Oct 4 2024, 2:10 AM

View All 90 Files

Subscribers

Details

Reviewers

Commits

rS313768: Port the Linux AMX 10G network driver to FreeBSD as axgbe. It is unlikely

Summary

Just the FreeBSD changes from D8548

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7442
Build 7604: arc lint + arc unit

Event Timeline

andrew updated this revision to Diff 22285.Nov 17 2016, 5:53 PM

andrew retitled this revision from to Port the Linux AMX xgbe driver to FreeBSD as axgbe.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

Herald added a subscriber: emaste. · View Herald TranscriptNov 17 2016, 5:53 PM

andrew retitled this revision from Port the Linux AMX xgbe driver to FreeBSD as axgbe to Port the Linux AMD xgbe driver to FreeBSD as axgbe.Nov 21 2016, 11:28 AM

andrew added a reviewer: gnn.

emaste added inline comments.Nov 21 2016, 6:53 PM

sys/dev/axgbe/xgbe-common.h
84–114	This is an interesting part of the license
sys/dev/axgbe/xgbe_osdep.h
51–67	given the other changes in the originally-Linux files, what do you think about changing them for this too rather than having the compatibility goop here?

Move xgbe.c to if_axgbe.c
Use sx_xlock/sx_xunlock directly
Add a license to xgbe_osdep.h
Support the new devicetree layout as documented in Linux

andrew marked an inline comment as done.Feb 9 2017, 5:28 PM

gnn added inline comments.Feb 12 2017, 7:55 PM

sys/dev/axgbe/if_axgbe.c
134	There's no multicast support?
sys/dev/axgbe/xgbe-dev.c
837	If this is old code, then why is it here?

andrew added inline comments.Feb 14 2017, 11:14 AM

sys/dev/axgbe/if_axgbe.c
134	Yes, however we don't yet pass the needed info to the hardware.

Remove dead code

gnn accepted this revision.Feb 14 2017, 1:26 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Feb 14 2017, 1:26 PM

Closed by commit rS313768: Port the Linux AMX 10G network driver to FreeBSD as axgbe. It is unlikely (authored by andrew). · Explain WhyFeb 15 2017, 1:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

conf/

1 line

conf/

5 lines

dev/

axgbe/

619 lines

34 lines

466 lines

872 lines

1368 lines

256 lines

224 lines

186 lines

Diff 25145

sys/arm64/conf/GENERIC

Loading...

sys/conf/files.arm64

Loading...

sys/dev/axgbe/if_axgbe.c

Loading...

sys/dev/axgbe/xgbe-common.h

Loading...

sys/dev/axgbe/xgbe-dcb.c

Loading...

sys/dev/axgbe/xgbe-debugfs.c

Loading...

sys/dev/axgbe/xgbe-desc.c

Loading...

sys/dev/axgbe/xgbe-dev.c

Loading...

sys/dev/axgbe/xgbe-drv.c

Loading...

sys/dev/axgbe/xgbe-ethtool.c

Loading...

sys/dev/axgbe/xgbe-main.c

Loading...

sys/dev/axgbe/xgbe-mdio.c

Loading...

sys/dev/axgbe/xgbe-ptp.c

Loading...

sys/dev/axgbe/xgbe.h

Loading...

sys/dev/axgbe/xgbe_osdep.h

Loading...