Page MenuHomeFreeBSD
Differential D9534

localtime: return NULL if time_t out of range of struct tm
ClosedPublic
Actions

Authored by emaste on Feb 10 2017, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 9:16 AM
Unknown Object (File)
Mon, Apr 29, 7:33 PM
Unknown Object (File)
Mon, Apr 29, 7:18 PM
Unknown Object (File)
Apr 4 2024, 2:54 AM
Unknown Object (File)
Mar 22 2024, 7:55 PM
Unknown Object (File)
Mar 22 2024, 7:55 PM
Unknown Object (File)
Mar 22 2024, 7:55 PM
Unknown Object (File)
Mar 9 2024, 8:30 AM
View All 48 Files
Subscribers
rafael.espindola_gmail.com

Details

Reviewers
bapt
Commits
rS313774: localtime: return NULL if time_t out of range of struct tm
Summary

Previously we would truncate tm.tm_year for time_ts corresponding to a year that does not fit in int.

This was fixed in tzcode in 2004 but has persisted in our tree rS2708.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 24988.Feb 10 2017, 9:24 PM
emaste retitled this revision from to localtime: return NULL if time_t out of range of struct tm.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: bapt.
emaste added a subscriber: rafael.espindola_gmail.com.

For reference, this broke the bash-static build with LLD: https://github.com/emaste/freebsd-ports/pull/20

bapt accepted this revision.Feb 12 2017, 5:44 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2017, 5:44 PM
Closed by commit rS313774: localtime: return NULL if time_t out of range of struct tm (authored by emaste). · Explain WhyFeb 15 2017, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
tzcode/
stdtime/
9 lines

Diff 24988

View Options

contrib/tzcode/stdtime/localtime.c

Loading...