update sysutils/mcelog to 148
ClosedPublic
Actions

Authored by lifanov on Feb 5 2017, 4:48 PM.

Details

Reviewers

matthew

Commits

rP433508: update sysutils/mcelog to 148

Summary

update sysutils/mcelog to 148

 - Intel Xeons from Ivy Bridge onwards support a processor identification number.
 - Fix warning with gcc 6.x
 - Makefile: Make `git` check portable (POSIX compatible)
 - replace asprintf with xasprintf as per memutil.c
 - Return -ENOMEM for vasprintf in sysfs_write

 PR: 216789
 Submitted by: ultima1252@gmail.com (maintainer)
 Reviewed by: matthew
 Approved by: matthew (mentor)
 Differential Revision: https://reviews.freebsd.org/DXXXX

Test Plan

poudriere testport - OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 7237
Build 7407: arc lint + arc unit

Event Timeline

lifanov updated this revision to Diff 24771.Feb 5 2017, 4:48 PM

lifanov retitled this revision from to update sysutils/mcelog to 148.

lifanov updated this object.

lifanov edited the test plan for this revision. (Show Details)

lifanov added a reviewer: matthew.

lifanov added a subscriber: koobs.

Herald added a subscriber: mat. · View Herald TranscriptFeb 5 2017, 4:48 PM

matthew added inline comments.Feb 5 2017, 5:26 PM

sysutils/mcelog/files/patch-Makefile
2–3	You shouldn't assume that `${PREFIX}` is `/usr/local` here. The best practice here is to substitute in a placeholder eg `%PREFIX%` via patch-Makefile and then use a `${REINPLACE_CMD}` call in `post-patch:` to replace that with the current value of `${PREFIX}`. This is easily broken and needs to be checked when preparing updates, because `make makepatch` will regenerate patches based on the state of `${WRKDIR}` after the `post-patch:` target has run, which unfortunately results in blowing away the placeholder from the patch files.