PCIe HotPlug: remove tests for DL active link capability
ClosedPublic
Actions

Authored by vangyzen on Feb 3 2017, 10:40 PM.

Details

Reviewers

Commits

rS313180: PCIe HotPlug: remove tests for DL active link capability

Summary

As of r313097, the HotPlug code requires the link to support
reporting of the data-link status. Remove tests for this capability
from code that can now assume its presence.

Suggested by: jhb

Test Plan

I no longer have ready access to HotPlug hardware,
so this is only boot-tested. If you'd like to test it,
I'd be grateful, but I'm comfortable committing it
essentially untested.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vangyzen updated this revision to Diff 24703.Feb 3 2017, 10:40 PM

vangyzen retitled this revision from to PCIe HotPlug: remove tests for DL active link capability.

vangyzen updated this object.

vangyzen edited the test plan for this revision. (Show Details)

vangyzen added a reviewer: jhb.

Looks good to me modulo the little nit.

sys/dev/pci/pci_pci.c
1383 ↗	(On Diff #24703)	I would stick DLLSCE at the beginning to match how 'mask' is initialized. (I think I did them in some sort of order, either MSB to LSB or vice versa.)

This revision is now accepted and ready to land.Feb 3 2017, 11:47 PM

vangyzen added inline comments.Feb 4 2017, 12:21 AM

sys/dev/pci/pci_pci.c
1383 ↗	(On Diff #24703)	mask is MSB to LSB, but val is the opposite. I'll sort val to match mask.

Closed by commit rS313180: PCIe HotPlug: remove tests for DL active link capability (authored by vangyzen). · Explain WhyFeb 4 2017, 12:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

pci/

pci_pci.c

44 lines

pcib_private.h

1 line

Diff 24706

View Options

head/sys/dev/pci/pci_pci.c

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines	struct ipstat {
uint64_t ips_nogif; /* no match gif found */		uint64_t ips_nogif; /* no match gif found */
uint64_t ips_badaddr; /* invalid address on header */		uint64_t ips_badaddr; /* invalid address on header */
};		};

#ifdef _KERNEL		#ifdef _KERNEL

#include <sys/counter.h>		#include <sys/counter.h>
#include <net/vnet.h>		#include <net/vnet.h>
		#include <netinet/in_kdtrace.h>

VNET_PCPUSTAT_DECLARE(struct ipstat, ipstat);		VNET_PCPUSTAT_DECLARE(struct ipstat, ipstat);
/*		/*
* In-kernel consumers can use these accessor macros directly to update		* In-kernel consumers can use these accessor macros directly to update
* stats.		* stats.
*/		*/
#define IPSTAT_ADD(name, val) \		#define IPSTAT_ADD(name, val) \
VNET_PCPUSTAT_ADD(struct ipstat, ipstat, name, (val))		do { \
		SDT_PROBE1(mib, ip, count, name, (val)); \
		VNET_PCPUSTAT_ADD(struct ipstat, ipstat, name, (val)); \
		} while (0)
#define IPSTAT_SUB(name, val) IPSTAT_ADD(name, -(val))		#define IPSTAT_SUB(name, val) IPSTAT_ADD(name, -(val))
#define IPSTAT_INC(name) IPSTAT_ADD(name, 1)		#define IPSTAT_INC(name) IPSTAT_ADD(name, 1)
#define IPSTAT_DEC(name) IPSTAT_SUB(name, 1)		#define IPSTAT_DEC(name) IPSTAT_SUB(name, 1)

/*		/*
* Kernel module consumers must use this accessor macro.		* Kernel module consumers must use this accessor macro.
*/		*/
void kmod_ipstat_inc(int statnum);		void kmod_ipstat_inc(int statnum);
#define KMOD_IPSTAT_INC(name) \		#define KMOD_IPSTAT_INC(name) \
kmod_ipstat_inc(offsetof(struct ipstat, name) / sizeof(uint64_t))		do { \
		SDT_PROBE1(mib, ip, count, name, 1); \
		kmod_ipstat_inc( \
		offsetof(struct ipstat, name) / sizeof(uint64_t)); \
		} while (0)
void kmod_ipstat_dec(int statnum);		void kmod_ipstat_dec(int statnum);
#define KMOD_IPSTAT_DEC(name) \		#define KMOD_IPSTAT_DEC(name) \
kmod_ipstat_dec(offsetof(struct ipstat, name) / sizeof(uint64_t))		do { \
		SDT_PROBE1(mib, ip, count, name, -1); \
		kmod_ipstat_dec( \
		offsetof(struct ipstat, name) / sizeof(uint64_t)); \
		} while (0)

/* flags passed to ip_output as last parameter */		/* flags passed to ip_output as last parameter */
#define IP_FORWARDING 0x1 /* most of ip header exists */		#define IP_FORWARDING 0x1 /* most of ip header exists */
#define IP_RAWOUTPUT 0x2 /* raw ip header exists */		#define IP_RAWOUTPUT 0x2 /* raw ip header exists */
#define IP_SENDONES 0x4 /* send all-ones broadcast */		#define IP_SENDONES 0x4 /* send all-ones broadcast */
#define IP_SENDTOIF 0x8 /* send on specific ifnet */		#define IP_SENDTOIF 0x8 /* send on specific ifnet */
#define IP_ROUTETOIF SO_DONTROUTE /* 0x10 bypass routing tables */		#define IP_ROUTETOIF SO_DONTROUTE /* 0x10 bypass routing tables */
#define IP_ALLOWBROADCAST SO_BROADCAST /* 0x20 can send broadcast packets */		#define IP_ALLOWBROADCAST SO_BROADCAST /* 0x20 can send broadcast packets */
▲ Show 20 Lines • Show All 177 Lines • Show Last 20 Lines