As of r313097, the HotPlug code requires the link to support
reporting of the data-link status. Remove tests for this capability
from code that can now assume its presence.
Suggested by: jhb
Details
Details
- Reviewers
jhb - Commits
- rS313180: PCIe HotPlug: remove tests for DL active link capability
I no longer have ready access to HotPlug hardware,
so this is only boot-tested. If you'd like to test it,
I'd be grateful, but I'm comfortable committing it
essentially untested.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good to me modulo the little nit.
| sys/dev/pci/pci_pci.c | ||
|---|---|---|
| 1383 ↗ | (On Diff #24703) | I would stick DLLSCE at the beginning to match how 'mask' is initialized. (I think I did them in some sort of order, either MSB to LSB or vice versa.) |
| sys/dev/pci/pci_pci.c | ||
|---|---|---|
| 1383 ↗ | (On Diff #24703) | mask is MSB to LSB, but val is the opposite. I'll sort val to match mask. |