PCIe HotPlug: remove tests for DL active link capability
ClosedPublic
Actions

Authored by vangyzen on Feb 3 2017, 10:40 PM.

Details

Reviewers

Commits

rS313180: PCIe HotPlug: remove tests for DL active link capability

Summary

As of r313097, the HotPlug code requires the link to support
reporting of the data-link status. Remove tests for this capability
from code that can now assume its presence.

Suggested by: jhb

Test Plan

I no longer have ready access to HotPlug hardware,
so this is only boot-tested. If you'd like to test it,
I'd be grateful, but I'm comfortable committing it
essentially untested.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7170
Build 7340: arc lint + arc unit

Event Timeline

vangyzen updated this revision to Diff 24703.Feb 3 2017, 10:40 PM

vangyzen retitled this revision from to PCIe HotPlug: remove tests for DL active link capability.

vangyzen updated this object.

vangyzen edited the test plan for this revision. (Show Details)

vangyzen added a reviewer: jhb.

Looks good to me modulo the little nit.

sys/dev/pci/pci_pci.c
1383	I would stick DLLSCE at the beginning to match how 'mask' is initialized. (I think I did them in some sort of order, either MSB to LSB or vice versa.)

This revision is now accepted and ready to land.Feb 3 2017, 11:47 PM

vangyzen added inline comments.Feb 4 2017, 12:21 AM