Differential D1189

Kill EXTRACT_PRESERVE_OWNERSHIP, update some comments
ClosedPublic
Actions

Authored by antoine on Nov 18 2014, 11:58 PM.

Details

Reviewers

antoine

Group Reviewers

portmgr

Summary

Kill EXTRACT_PRESERVE_OWNERSHIP, update some comments

Test Plan

Verify it still builds

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

antoine updated this revision to Diff 2452.Nov 18 2014, 11:58 PM

antoine retitled this revision from to Kill EXTRACT_PRESERVE_OWNERSHIP, update some comments.

antoine updated this object.

antoine edited the test plan for this revision. (Show Details)

Herald added a reviewer: portmgr. · View Herald TranscriptNov 18 2014, 11:58 PM

I accept my revision

This revision is now accepted and ready to land.Dec 14 2014, 11:05 AM

antoine closed this revision.Dec 14 2014, 11:46 AM

What is the "Why" here? This is useful for NFS checkouts where using root squash.

There was no mention of root-squash in the commit log or in the comment so I didn't think about it.

I can put back the .if !defined(EXTRACT_PRESERVE_OWNERSHIP) around the CHMOD/CHOWN.

For --no-same-owner --no-same-permissions, I think it doesn't harm with root-squash. Do you confirm?

In D1189#10, @antoine wrote:

There was no mention of root-squash in the commit log or in the comment so I didn't think about it.

I can put back the .if !defined(EXTRACT_PRESERVE_OWNERSHIP) around the CHMOD/CHOWN.

For --no-same-owner --no-same-permissions, I think it doesn't harm with root-squash. Do you confirm?

I'll experiment and get back to you.