Page MenuHomeFreeBSD

Kill EXTRACT_PRESERVE_OWNERSHIP, update some comments
ClosedPublic

Authored by antoine on Nov 18 2014, 11:58 PM.
Tags
None
Referenced Files
F132189215: D1189.id2452.diff
Tue, Oct 14, 3:01 PM
F132189210: D1189.id.diff
Tue, Oct 14, 3:01 PM
Unknown Object (File)
Mon, Oct 13, 3:19 AM
Unknown Object (File)
Sun, Oct 12, 6:27 PM
Unknown Object (File)
Fri, Sep 19, 4:46 PM
Unknown Object (File)
Tue, Sep 16, 9:40 PM
Unknown Object (File)
Sep 13 2025, 4:59 AM
Unknown Object (File)
Sep 12 2025, 5:20 PM
Subscribers

Details

Reviewers
antoine
Group Reviewers
portmgr
Summary

Kill EXTRACT_PRESERVE_OWNERSHIP, update some comments

Test Plan

Verify it still builds

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

antoine retitled this revision from to Kill EXTRACT_PRESERVE_OWNERSHIP, update some comments.
antoine updated this object.
antoine edited the test plan for this revision. (Show Details)
antoine added a reviewer: antoine.

I accept my revision

This revision is now accepted and ready to land.Dec 14 2014, 11:05 AM

What is the "Why" here? This is useful for NFS checkouts where using root squash.

There was no mention of root-squash in the commit log or in the comment so I didn't think about it.

I can put back the .if !defined(EXTRACT_PRESERVE_OWNERSHIP) around the CHMOD/CHOWN.

For --no-same-owner --no-same-permissions, I think it doesn't harm with root-squash. Do you confirm?

In D1189#10, @antoine wrote:

There was no mention of root-squash in the commit log or in the comment so I didn't think about it.

I can put back the .if !defined(EXTRACT_PRESERVE_OWNERSHIP) around the CHMOD/CHOWN.

For --no-same-owner --no-same-permissions, I think it doesn't harm with root-squash. Do you confirm?

I'll experiment and get back to you.