set -mlong-calls on arm also in LLVM's STATIC_CFLAGS
ClosedPublic
Actions

Authored by emaste on Jan 26 2017, 1:54 PM.

Details

Reviewers

dim
andrew

Commits

rS312898: Add -mlong-calls also to LLVM's STATIC_CFLAGS on ARM

Summary

-mlong-calls was set only in STATIC_CXXFLAGS, but there are some .c source files in LLVM which also need -mlong-calls.

Unfortunately this is not sufficient to fix linking lldb on arm:

/tank/emaste/obj/arm.armv6/tank/emaste/src/freebsd-staging/lib/clang/libllvm/libllvm.a(regexec.o): In function `llvm_regexec':
/tank/emaste/src/freebsd-staging/contrib/llvm/lib/Support/regexec.c:(.text+0x260): relocation truncated to fit: R_ARM_CALL against symbol `__aeabi_read_tp@@FBSDprivate_1.0' defined in .plt section in /tank/emaste/obj/arm.armv6/tank/emaste/src/freebsd-staging/lib/clang/libllvm/libllvm.a(regexec.o)

because it seems compiler-inserted __aeabi_read_tp calls don't honour -mlong-calls (clang400 branch) - we get:

260:       fe ff ff eb     bl      #-8 <llvm_regexec+0x260>
                   00000260:  R_ARM_CALL   __aeabi_read_tp

But this is part of the fix

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 24472.Jan 26 2017, 1:54 PM

emaste retitled this revision from to set -mlong-calls on arm also in LLVM's STATIC_CFLAGS.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: dim, andrew.

LLVM bug report https://llvm.org/bugs/show_bug.cgi?id=31769

dim accepted this revision.Jan 27 2017, 9:23 PM

dim edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2017, 9:23 PM

Closed by commit rS312898: Add -mlong-calls also to LLVM's STATIC_CFLAGS on ARM (authored by emaste). · Explain WhyJan 27 2017, 9:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

clang/

llvm.build.mk

1 line

Diff 24472

View Options

set -mlong-calls on arm also in LLVM's STATIC_CFLAGSClosedPublicActions