Differential D9195

[net80211] initial "driver does sequence number handling" This implements: * optionally deferring sequence number allocation into the driver * don't grab/release the net80211 TX lock if the driver does sequence number allocation * write a...
Needs ReviewPublic
Actions

Authored by adrian on Jan 16 2017, 4:01 AM.

Details

Reviewers

avos

Group Reviewers

network

Summary

...net80211 function that will assign sequence numbers to

frames (which I haven't yet completely vetted!)

teach ath(4) about using this new function to fill out sequence numbers for frames as appropriate.

ath(4) - STA mode only; not IBSS or hostap modes yet!

TODO:

Go look at whether cabq frames should have sequence numbers allocated /after/ the beacon frame sequence numbers, for non-QoS data frames.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6796
Build 7006: arc lint + arc unit

Event Timeline

adrian updated this revision to Diff 24058.Jan 16 2017, 4:01 AM

adrian retitled this revision from to [net80211] initial "driver does sequence number handling" This implements: * optionally deferring sequence number allocation into the driver * don't grab/release the net80211 TX lock if the driver does sequence number allocation * write a....

adrian updated this object.

adrian edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2017, 4:01 AM

Yeah ,there are other comments in ath(4) that aren't part of this commit.

adrian added reviewers: network, avos.Jan 16 2017, 4:02 AM

avos added inline comments.Jan 18 2017, 11:24 PM

sys/net80211/ieee80211_output.c
3736	duplicates IEEE80211_HAS_SEQ check; one of them is not needed.
3774	already dropped after IEEE80211_HAS_SEQ check
3793	looks like ieee80211_fragment() will be broken after this change (not too critical since fragment number is usually assigned by firmware).