Page MenuHomeFreeBSD
Differential D9128

PR 213560 upgrade www/obhttpd to 6.0
ClosedPublic
Actions

Authored by ler on Jan 11 2017, 4:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 23, 1:45 PM
Unknown Object (File)
Wed, Oct 23, 11:56 AM
Unknown Object (File)
Wed, Oct 23, 8:46 AM
Unknown Object (File)
Mon, Oct 21, 7:45 PM
Unknown Object (File)
Mon, Oct 21, 10:15 AM
Unknown Object (File)
Sun, Oct 20, 1:11 PM
Unknown Object (File)
Oct 18 2024, 12:06 PM
Unknown Object (File)
Oct 17 2024, 8:50 AM
View All Files
Subscribers
mat

Details

Reviewers
adamw
rene
Commits
rP431157: upgrade www/obhttpd to 6.0.20161006
Summary

upgrade www/obhttpd to 6.0.20161006
modernized the Uses / USE_OPENSSL usage

PR: 213560
Submitted by: koue@chaosophia.net (Maintainer)
Approved by: adamw (mentor)

Test Plan

poudriere testport (ok)
portlint -Ac (ok)

I'll also mention "committed with minor changes" in the PR close message

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ler updated this revision to Diff 23866.Jan 11 2017, 4:15 AM
ler retitled this revision from to PR 213560 upgrade www/obhttpd to 6.0.
ler updated this object.
ler edited the test plan for this revision. (Show Details)
ler added reviewers: adamw, rene.
ler set the repository for this revision to rP FreeBSD ports repository.
Herald added a subscriber: mat. · View Herald TranscriptJan 11 2017, 4:15 AM
ler updated this object.Jan 11 2017, 4:15 AM
adamw added inline comments.Jan 11 2017, 4:21 AM
Makefile
12

That doesn't look right.

Try just
WRKSRC_SUBDIR= src

41

What about just

${INSTALL_DATA} ${WRKSRC}/etc/examples...

adamw edited edge metadata.Jan 11 2017, 4:30 AM

You need to add the pkg-plist here as well.

ler added inline comments.Jan 11 2017, 4:32 AM
Makefile
12

> Patching for obhttpd-6.0.20161006

/usr/bin/sed -i.bak -e 's|httpd$|obhttpd|g' -e 's|httpd.conf.5|obhttpd.conf.5|g' -e 's|httpd.8|obhttpd.8|g' src/usr.sbin/httpd/Makefile
sed: src/usr.sbin/httpd/Makefile: No such file or directory

  • Error code 1
ler updated this revision to Diff 23867.Jan 11 2017, 4:35 AM
ler edited edge metadata.

added pkg-plist. trying wrksrc = src fails

adamw added inline comments.Jan 11 2017, 4:36 AM
Makefile
12

I think you set WRKSRC, not WRKSRC_SUBDIR.

adamw added inline comments.Jan 11 2017, 4:38 AM
pkg-plist
2

This should be a @sample.

ler updated this revision to Diff 23868.Jan 11 2017, 4:41 AM
ler edited the test plan for this revision. (Show Details)

address adamw's comments

ler updated this revision to Diff 23869.EditedJan 11 2017, 4:43 AM

@sample added

ler marked 4 inline comments as done.Jan 11 2017, 4:45 AM
adamw added inline comments.Jan 11 2017, 4:47 AM
Makefile
47

One last thing. This message looks really sloppy when printed.

s/need/needs/, s/set/Set/

ler updated this revision to Diff 23870.Jan 11 2017, 4:50 AM

IGNORE message fixups.

ler marked 2 inline comments as done.Jan 11 2017, 4:52 AM

address comments

adamw accepted this revision.Jan 11 2017, 4:54 AM
adamw edited edge metadata.

Phew! Okay good work.

In your PR close message, ask Nikola to take a look at net/openntpd and security/acme-client and see whether that setup would work for this port too.

This revision is now accepted and ready to land.Jan 11 2017, 4:54 AM
Closed by commit rP431157: upgrade www/obhttpd to 6.0.20161006 (authored by ler). · Explain WhyJan 11 2017, 4:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
30 lines
5 lines
7 lines

Diff 23869

View Options

Makefile

Loading...
View Options

distinfo

Loading...
View Options

pkg-plist

Loading...