Details
Details
- Reviewers
jhb - Commits
- rS312913: Improve the aio tests
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6648 Build 6866: arc lint + arc unit
Event Timeline
Comment Actions
This looks fine overall. I think it wouldn't be bad if we had an aio_suspend test of all the various file types, not just for vnodes.
| tests/sys/aio/aio_test.c | ||
|---|---|---|
| 1170 | These are roughly in order that the functions are defined, so I think this should be moved up? | |
Comment Actions
Substantially update review:
- add tests for polled completion notification
- test the full matrix of file descriptor types and completion notification mechanisms.
- Don't bother with mkstemp, because ATF runs every test in its own temp dir.
- Fix some typos
- Remove extraneous ATF_REQUIRE_KERNEL_MODULE calls
| tests/sys/aio/aio_test.c | ||
|---|---|---|
| 77 | I would put a blank line here (I know it was missing in the original code) | |
| 221 | You might want to ATF_REQUIRE that the returned aiocb from aio_waitcomplete() matches the passed in aiocb. | |
| 384 | Only caveat about removing mkstemp() is that I often run tests standalone. In particular, kyua has very poor integration with debuggers, so the only way to single step a test to debug a failure is to run it outside of kyua. :-/ | |