Details

Reviewers

Group Reviewers

portmgr
Perl

Summary

Currently, we install modules which are not versionned at all in a versionned way:

site_perl :      lib/perl5/site_perl/5.18
site_perl_arch : lib/perl5/site_perl/5.18/mach

This changes the layout to:

site_perl :      lib/perl5/site_perl
site_perl_arch : lib/perl5/site_perl/mach/5.18

Allows to have all modules without any .so installed at the same place
whatever the Perl version is, and allows to have versionned versions of the
modules with .so.

Introduce a new plist replacement, SITE_ARCH, containing SITE_PERL/PERL_ARCH/PERL_VER

Remove perllocal.pod from Mk/Uses/perl5.mk, and cleanup ports installing/removing it.

Test Plan

exp-run to hell

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

mat updated this revision to Diff 2133.Oct 28 2014, 2:06 PM

mat retitled this revision from to Change how Perl modules are installed.

mat updated this object.

mat edited the test plan for this revision. (Show Details)

mat added reviewers: Perl, portmgr.

Herald edited edge metadata. · View Herald TranscriptOct 28 2014, 2:06 PM

With Perl 5.18 actually building.

I really like this one :)

Toss in a few converted ports.

mat updated this object.Oct 29 2014, 1:12 PM

mat edited the test plan for this revision. (Show Details)

Centralize removing perllocal.pod

Add all ports from the lang category.

The full patch is available at:
https://people.freebsd.org/~mat/patches/new-perl-order.diff

antoine added a subscriber: antoine.Oct 30 2014, 5:48 PM

antoine added inline comments.

Mk/Uses/perl5.mk
100	why ${PERL_ARCH}/${PERL_VER} and not ${PERL_VER}/${PERL_ARCH} ?

mat added inline comments.Oct 30 2014, 11:46 PM

Mk/Uses/perl5.mk
100	Well, that way, all of perl .so end up in ${PERL_ARCH} with on subdirectory for each perl version.

Be kind to our users and keep the old directories in @INC.

For all Perl versions.

Finaly, remove .packlist files.

Add three @dir that should stay.

Update.

Add CHANGES and UPDATING to the review.

Enhance the texts a bit.

mat added inline comments.Nov 14 2014, 2:13 PM

Mk/bsd.port.mk
5951	I moved the Perl bits before post-install so that ports doing auto-plist in there don't catch files that will be removed afterwards.

Be more consistent.

brueffer added a subscriber: brueffer.Nov 24 2014, 11:28 AM

brueffer added inline comments.

CHANGES
28 ↗	(On Diff #2480)	s/whatever the Perl version is/regardless of the Perl version/
41 ↗	(On Diff #2480)	"...these old Perl..." Perl versions perhaps?
Mk/Uses/perl5.mk
289	s/no/to/
UPDATING
18 ↗	(On Diff #2480)	s/another/a different/
30 ↗	(On Diff #2480)	5.18 I suppose?

Update.

mat accepted this revision.Nov 26 2014, 1:27 PM

mat added a reviewer: mat.

This revision is now accepted and ready to land.Nov 26 2014, 1:27 PM

mat closed this revision.Nov 26 2014, 1:30 PM

Change how Perl modules are installedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2375

Mk/Uses/perl5.mk

Mk/bsd.default-versions.mk

Mk/bsd.port.mk

lang/p5-Data-JavaScript/pkg-plist

lang/p5-Error/pkg-plist

lang/p5-Expect/pkg-plist

lang/p5-ExtUtils-F77/pkg-plist

lang/p5-Interpolation/pkg-plist

lang/p5-JSAN/pkg-plist

lang/p5-JavaScript-SpiderMonkey/pkg-plist

lang/p5-JavaScript-Squish/pkg-plist

lang/p5-JavaScript-Value-Escape/pkg-plist

lang/p5-List-MoreUtils/pkg-plist

lang/p5-Marpa-XS/pkg-plist

lang/p5-Marpa/pkg-plist

lang/p5-Parse-Perl/pkg-plist

lang/p5-Perl6-Subs/pkg-plist

lang/p5-Pugs-Compiler-Rule/pkg-plist

lang/p5-Quantum-Superpositions/pkg-plist

lang/p5-Scalar-List-Utils/pkg-plist

lang/p5-Switch/pkg-plist

lang/p5-Tcl/pkg-plist

lang/p5-Try-Tiny-Retry/pkg-plist

lang/p5-Try-Tiny/pkg-plist

lang/p5-TryCatch/pkg-plist

lang/p5-ePerl/pkg-plist

lang/p5-signatures/pkg-plist

lang/p5-v6/pkg-plist

lang/perl5.14/Makefile

lang/perl5.14/pkg-plist

lang/perl5.16/Makefile

lang/perl5.16/pkg-plist

lang/perl5.18/Makefile

lang/perl5.18/pkg-plist

lang/perl5.20/Makefile

lang/perl5.20/pkg-plist

Change how Perl modules are installed
ClosedPublic
Actions

Revision Contents
Changeset List