Page MenuHomeFreeBSD
Differential D9086

sysutils/zap: Update to version 0.6.4.
ClosedPublic
Actions

Authored by jrm on Jan 8 2017, 5:30 AM.
Tags
None
Referenced Files
F107344291: D9086.diff
Sun, Jan 12, 7:12 PM
Unknown Object (File)
Nov 28 2024, 7:47 AM
Unknown Object (File)
Nov 25 2024, 7:17 PM
Unknown Object (File)
Nov 17 2024, 10:22 AM
Unknown Object (File)
Nov 17 2024, 1:01 AM
Unknown Object (File)
Nov 11 2024, 12:06 PM
Unknown Object (File)
Nov 11 2024, 6:08 AM
Unknown Object (File)
Nov 6 2024, 5:08 AM
View All Files
Subscribers
mat

Details

Reviewers
swills
AMDmi3
Commits
rP431024: sysutils/zap: Update to version 0.6.4.
Summary

sysutils/zap: Update to version 0.6.4.

  • Fix issues with replication.
    • Do not require all '-r dataset' arguments to be listed first.
    • Fix error checking. If only one argument to 'zap rep' was supplied, replication would silently fail. This required breaking the interface. Instead of zap rep|replicate [-dLSv] [[-r dataset]... [dataset]... remote_dest] the format is now zap rep|replicate [-dLSv] [remote_dest [-r] dataset [[-r] dataset]...].
  • Fix issue with destroy.
    • In 0.6.3 $zptn was updated to be an extended regular expression, but when a host was not supplied as an argument, grep was being called with a basic regular expression.
  • In 'zap snap', do not require all '-r dataset' arguments to be listed first.
Test Plan

portlint -C
testport: OK (poudriere: 11.0-RELEASE-p1, amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6632
Build 6850: arc lint + arc unit

Event Timeline

jrm updated this revision to Diff 23728.Jan 8 2017, 5:30 AM
jrm retitled this revision from to sysutils/zap: Update to version 0.6.4..
jrm updated this object.
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: swills, AMDmi3.
Herald added a subscriber: mat. · View Herald TranscriptJan 8 2017, 5:30 AM
AMDmi3 requested changes to this revision.Jan 9 2017, 1:36 PM
AMDmi3 edited edge metadata.

IMO pkg-message should be removed, and the note on arguments format update moved to UPDATING.

This revision now requires changes to proceed.Jan 9 2017, 1:36 PM
jrm updated this revision to Diff 23769.Jan 9 2017, 1:57 PM
jrm edited edge metadata.

Move warning about changes from pkg-message to UPDATING.

AMDmi3 requested changes to this revision.Jan 9 2017, 2:03 PM
AMDmi3 edited edge metadata.

Umm, this needs formatting fix (2 space indent) and at least some description on what has changed.
And 0.6.0 related message should be moved into its own entry with earlier date, placed correspondingly to keep UPDATING sorted by date.

This revision now requires changes to proceed.Jan 9 2017, 2:03 PM
jrm updated this revision to Diff 23773.Jan 9 2017, 2:38 PM
jrm edited edge metadata.

Fix formatting and provide more detail in UPDATING entry. Refer users to the UPDATING entries in pkg-message.

jrm updated this revision to Diff 23774.EditedJan 9 2017, 2:40 PM
jrm edited edge metadata.

Tweak UPDATING text.

AMDmi3 added a comment.Jan 9 2017, 3:29 PM

Please remove pkg-message, it's useless; otherwise LGTM

jrm added a comment.Jan 9 2017, 3:40 PM

While users should always look in UPDATING, they often don't (based on forum and mailing list questions). I hope they will not miss these messages, otherwise they will run in to problems. I think the pkg-message will make it less likely that they miss the message, because they will see it when they update the package.

AMDmi3 requested changes to this revision.Jan 9 2017, 4:05 PM
AMDmi3 edited edge metadata.

While users should always look in UPDATING, they often don't

It's the same for pkg-messages. If a user doesn't want to look into updating instructions, you can't help him. Duplicating instructions in pkg-message won't help either. Instead, it will only increase noise for all users and break POLA (UPDATING is (only) for updating instructions, pkg-message is (only) for post-installation manual actions and FreeBSD-specific quirks).

This revision now requires changes to proceed.Jan 9 2017, 4:05 PM
jrm updated this revision to Diff 23779.Jan 9 2017, 4:16 PM
jrm edited edge metadata.

Remove pkg-message.

swills edited edge metadata.Jan 9 2017, 6:50 PM

pkg-message is more appropriate. The message is for users of the package, not all users of ports and UPDATING isn't going to be seen by anyone who uses pkg update anyway, so if nothing else you need BOTH.

jrm updated this revision to Diff 23786.Jan 9 2017, 7:04 PM
jrm edited edge metadata.

Revert back to just a pkg-message and no UPDATING entries.

swills accepted this revision.Jan 9 2017, 7:24 PM
swills edited edge metadata.

Approved

Closed by commit rP431024: sysutils/zap: Update to version 0.6.4. (authored by jrm). · Explain WhyJan 9 2017, 7:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sysutils/
zap/
2 lines
6 lines
4 lines

Diff 23728

View Options

sysutils/zap/Makefile

Loading...
View Options

sysutils/zap/distinfo

Loading...
View Options

sysutils/zap/pkg-message

Loading...