Page MenuHomeFreeBSD
Differential D9085

Update diffoscope to 67
ClosedPublic
Actions

Authored by bapt on Jan 7 2017, 10:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 4:10 AM
Unknown Object (File)
Mar 3 2025, 12:00 AM
Unknown Object (File)
Feb 23 2025, 1:50 PM
Unknown Object (File)
Feb 18 2025, 11:15 AM
Unknown Object (File)
Feb 14 2025, 5:20 AM
Unknown Object (File)
Feb 13 2025, 10:38 PM
Unknown Object (File)
Feb 9 2025, 10:38 PM
Unknown Object (File)
Jan 5 2025, 4:08 AM
View All 45 Files
Subscribers
mat

Details

Reviewers
koobs
Commits
rP433526: Update to 67
Summary

All patches for freebsd from reproducible build have been integrated
In particular no more requirement for /dev/fd

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6631
Build 6849: arc lint + arc unit

Event Timeline

bapt updated this revision to Diff 23725.Jan 7 2017, 10:57 PM
bapt retitled this revision from to Update diffoscope to 67.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: koobs.
Herald added a subscriber: mat. · View Herald TranscriptJan 7 2017, 10:57 PM
Closed by commit rP433526: Update to 67 (authored by bapt). · Explain WhyFeb 6 2017, 10:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23725

View Options

sysutils/py-diffoscope/Makefile

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
done done
umask 377 umask 377
n=$(( ${entropy_save_num} - 1 )) n=$(( ${entropy_save_num} - 1 ))
while [ ${n} -ge 1 ]; do while [ ${n} -ge 1 ]; do
if [ -f "saved-entropy.${n}" ]; then if [ -f "saved-entropy.${n}" ]; then
mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))" mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
delphijUnsubmitted
Not Done
Inline Actions

fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync.

delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
cemAuthorUnsubmitted
Done
Inline Actions

If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file.

cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
logger -is -t "$0" \ logger -is -t "$0" \
"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \ "${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
it will not be rotated. Entropy file rotation is aborted. it will not be rotated. Entropy file rotation is aborted.
exit 1 exit 1
fi fi
n=$(( ${n} - 1 )) n=$(( ${n} - 1 ))
done done
dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
fsync saved-entropy.1 "."
delphijUnsubmitted
Done
Inline Actions

This can be merged with the '.' (fsync saved-entropy.1 .).

delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
cemAuthorUnsubmitted
Done
Inline Actions

Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.
exit 0 exit 0
View Options

sysutils/py-diffoscope/distinfo

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
done done
umask 377 umask 377
n=$(( ${entropy_save_num} - 1 )) n=$(( ${entropy_save_num} - 1 ))
while [ ${n} -ge 1 ]; do while [ ${n} -ge 1 ]; do
if [ -f "saved-entropy.${n}" ]; then if [ -f "saved-entropy.${n}" ]; then
mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))" mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
delphijUnsubmitted
Not Done
Inline Actions

fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync.

delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
cemAuthorUnsubmitted
Done
Inline Actions

If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file.

cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
logger -is -t "$0" \ logger -is -t "$0" \
"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \ "${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
it will not be rotated. Entropy file rotation is aborted. it will not be rotated. Entropy file rotation is aborted.
exit 1 exit 1
fi fi
n=$(( ${n} - 1 )) n=$(( ${n} - 1 ))
done done
dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
fsync saved-entropy.1 "."
delphijUnsubmitted
Done
Inline Actions

This can be merged with the '.' (fsync saved-entropy.1 .).

delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
cemAuthorUnsubmitted
Done
Inline Actions

Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.
exit 0 exit 0
View Options

sysutils/py-diffoscope/files/

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
done done
umask 377 umask 377
n=$(( ${entropy_save_num} - 1 )) n=$(( ${entropy_save_num} - 1 ))
while [ ${n} -ge 1 ]; do while [ ${n} -ge 1 ]; do
if [ -f "saved-entropy.${n}" ]; then if [ -f "saved-entropy.${n}" ]; then
mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))" mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
delphijUnsubmitted
Not Done
Inline Actions

fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync.

delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
cemAuthorUnsubmitted
Done
Inline Actions

If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file.

cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
logger -is -t "$0" \ logger -is -t "$0" \
"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \ "${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
it will not be rotated. Entropy file rotation is aborted. it will not be rotated. Entropy file rotation is aborted.
exit 1 exit 1
fi fi
n=$(( ${n} - 1 )) n=$(( ${n} - 1 ))
done done
dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
fsync saved-entropy.1 "."
delphijUnsubmitted
Done
Inline Actions

This can be merged with the '.' (fsync saved-entropy.1 .).

delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
cemAuthorUnsubmitted
Done
Inline Actions

Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.
exit 0 exit 0
View Options

sysutils/py-diffoscope/files/patch-diffoscope_comparators_directory.py

Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Lines
done done
umask 377 umask 377
n=$(( ${entropy_save_num} - 1 )) n=$(( ${entropy_save_num} - 1 ))
while [ ${n} -ge 1 ]; do while [ ${n} -ge 1 ]; do
if [ -f "saved-entropy.${n}" ]; then if [ -f "saved-entropy.${n}" ]; then
mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))" mv "saved-entropy.${n}" "saved-entropy.$(( ${n} + 1 ))"
elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then elif [ -e "saved-entropy.${n}" -o -L "saved-entropy.${n}" ]; then
delphijUnsubmitted
Not Done
Inline Actions

fsync'ing the directory node would result in more writes and I think we can tolerate if it failed to sync.

delphij: fsync'ing the directory node would result in more writes and I think we can tolerate if it…
cemAuthorUnsubmitted
Done
Inline Actions

If a small number of additional writes is a problem, and we can tolerate losing every rotated file (by lost dirent reference), I propose that we can save even more writes by keeping only one entropy file.

cem: If a small number of additional writes is a problem, and we can tolerate losing every rotated…
logger -is -t "$0" \ logger -is -t "$0" \
"${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \ "${entropy_dir}/saved-entropy.${n}" is not a regular file, and so \
it will not be rotated. Entropy file rotation is aborted. it will not be rotated. Entropy file rotation is aborted.
exit 1 exit 1
fi fi
n=$(( ${n} - 1 )) n=$(( ${n} - 1 ))
done done
dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null dd if=/dev/random of=saved-entropy.1 bs=${entropy_save_sz} count=1 2>/dev/null
fsync saved-entropy.1 "."
delphijUnsubmitted
Done
Inline Actions

This can be merged with the '.' (fsync saved-entropy.1 .).

delphij: This can be merged with the '.' (fsync saved-entropy.1 .).
cemAuthorUnsubmitted
Done
Inline Actions

Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.

cem: Ah, I did not realize fsync(1) took a list of files! Thank you, I'll fix it.
exit 0 exit 0
View Options

sysutils/py-diffoscope/pkg-message

Loading...