Differential D1140

Upgrading math/atlas to 3.10.2
AbandonedPublic
Actions

Authored by thierry on Nov 11 2014, 9:59 AM.

Tags

None

Referenced Files

	F169797505: D1140.id.diff
	Wed, Sep 2, 2:39 PM

	Unknown Object (File)
	Wed, Sep 2, 10:30 AM

	Unknown Object (File)
	Wed, Sep 2, 7:11 AM

	Unknown Object (File)
	Wed, Sep 2, 2:41 AM

	Unknown Object (File)
	Mon, Aug 31, 2:28 PM

	Unknown Object (File)
	Mon, Aug 31, 10:46 AM

	Unknown Object (File)
	Mon, Aug 31, 7:25 AM

	Unknown Object (File)
	Tue, Aug 25, 5:13 PM

Subscribers

None

Tokens

"Like" token, awarded by pfg.

Details

Reviewers

Summary

math/atlas is an important port, but a complex one, and I'd like a pair review before committing it.

The attached patch is almost ready, but it still contains unused variables from the previous version and it needs a @mode in plist, but I'd like to be sure that it's OK before going further.

Test Plan

All tests passed, but some symbols are missing and it needs to be linked with "-llapack -lblas". It seems that it was already so previously (LIB_DEPENDS+= libblas.so if MAINTAINER_MODE), but anyway that seems strange...

Tested with some other ports depending on libatlas.

(Notice sent to maho@ )

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

thierry updated this revision to Diff 2351.Nov 11 2014, 9:59 AM

thierry retitled this revision from to Upgrading math/atlas to 3.10.2.

thierry updated this object.

thierry edited the test plan for this revision. (Show Details)

thierry added a reviewer: pfg.

thierry set the repository for this revision to rP FreeBSD ports repository.

I think this is OK.

On the long run we should probably deprecate Atlas and just use OpenBlas for everything.

pfg awarded a token.Dec 22 2014, 7:08 PM

Thanks Pedro!

I've just proposed a new revision
https://reviews.freebsd.org/D1354
to handle the different Blas/lapack options, and set OpenBlas by default.

For an unknown reason, it does not build anymore with the attached patch.
It needs some time to investigate and hopefully to fix.

Revision Contents
Changeset List

Path

Size

math/

atlas/

143 lines

4 lines

files/

patch-CONFIG+src+SpewMakeInc.c

70 lines

patch-CONFIG+src+backend+archinfo_freebsd.c

94 lines

patch-CONFIG+src+backend+archinfo_x86.c

14 lines

patch-CONFIG+src+config.c

20 lines

11 lines

patch-bin+atlas_install.c

10 lines

patch-tmpnamleak

68 lines

patch-tune+sysinfo+emit_buildinfo.c

22 lines

1028 lines

Diff 2351

math/atlas/Makefile

Loading...

math/atlas/distinfo

Loading...

math/atlas/files/patch-CONFIG+src+SpewMakeInc.c

Loading...

math/atlas/files/patch-CONFIG+src+backend+archinfo_freebsd.c

Loading...

math/atlas/files/patch-CONFIG+src+backend+archinfo_x86.c

Loading...

math/atlas/files/patch-CONFIG+src+config.c

Loading...

math/atlas/files/patch-Make.top

Loading...

math/atlas/files/patch-bin+atlas_install.c

Loading...

math/atlas/files/patch-tmpnamleak

Loading...

math/atlas/files/patch-tune+sysinfo+emit_buildinfo.c

Loading...

math/atlas/pkg-plist

Loading...