indent(1): add option -P for loading user-provided files as profiles
ClosedPublic
Actions

Authored by pstef on Dec 31 2016, 12:37 PM.

Details

Reviewers

Commits

rS311138: indent(1): add option -P for loading user-provided files as profiles

Summary

Without this patch, indent(1) will only look to load options from ~/.indent.pro if it's there and -npro wasn't used on the command line. This option lets the user set their own path to the file.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

pstef updated this revision to Diff 23489.Dec 31 2016, 12:37 PM

pstef retitled this revision from to indent(1): add option -P for loading user-provided files as profiles.

pstef updated this object.

pstef edited the test plan for this revision. (Show Details)

pstef added a child revision: D9007: Add regression tests for indent(1).

pstef mentioned this in D9007: Add regression tests for indent(1).Dec 31 2016, 12:42 PM

pstef added inline comments.Dec 31 2016, 1:49 PM

args.c
102	The option "V" is an artefact from my local changes that I'm not going to commit; pay no attention to it.

pstef added a reviewer: pfg.Jan 1 2017, 8:45 PM

pstef set the repository for this revision to rS FreeBSD src repository - subversion.

Given that there is a "-npro" option already, how about renaming it to "-ppro"? This would stand for "personalized profile", but I guess we could use custom profile (-cpro) or temporary profile (-tpro). Just trying to make things look consistent ;).

args.c
102	Please rebase the diff on top of the FreeBSD version. You will need that to commit it anyway.

pfg added inline comments.Jan 1 2017, 9:07 PM

indent.1
69	When updating content for a manpage you should also update the date on the top of this file.

Given that there is a "-npro" option already, how about renaming it to "-ppro"? This would stand for "personalized profile", but I guess we could use custom profile (-cpro) or temporary profile (-tpro). Just trying to make things look consistent ;).

The lower-case options either take no parameter or take a numeric parameter. Only special options (upper-case, single letter) -U and -T take parameters in string form.

args.c
102	Will do.
indent.1
69	Will do.

"-P" is OK then.
I can't check easily the length of the lines in phabricator but it's probably fine too as I see longer lines in the original code.

Rebased on top of SVN.
Updated date in the man page.

Approved: however, do remember to add a line

Differential Revision: Revision URL

as the last line in your log.

indent.c
97	It is not strictly wrong, as this code has it's own style, but just FYI: Per our style, initialization should be done in line 194, right before profile_name is used. However, this program has an initialization section so it should be there. OTOH, they also do some initializations in the declaration section, so you can leave it there :-P.