Without this patch, indent(1) will only look to load options from ~/.indent.pro if it's there and -npro wasn't used on the command line. This option lets the user set their own path to the file.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| args.c | ||
|---|---|---|
| 102 ↗ | (On Diff #23489) | The option "V" is an artefact from my local changes that I'm not going to commit; pay no attention to it. |
Comment Actions
Given that there is a "-npro" option already, how about renaming it to "-ppro"? This would stand for "personalized profile", but I guess we could use custom profile (-cpro) or temporary profile (-tpro). Just trying to make things look consistent ;).
| args.c | ||
|---|---|---|
| 102 ↗ | (On Diff #23489) | Please rebase the diff on top of the FreeBSD version. You will need that to commit it anyway. |
| indent.1 | ||
|---|---|---|
| 69 ↗ | (On Diff #23489) | When updating content for a manpage you should also update the date on the top of this file. |
Comment Actions
Given that there is a "-npro" option already, how about renaming it to "-ppro"? This would stand for "personalized profile", but I guess we could use custom profile (-cpro) or temporary profile (-tpro). Just trying to make things look consistent ;).
The lower-case options either take no parameter or take a numeric parameter. Only special options (upper-case, single letter) -U and -T take parameters in string form.
| args.c | ||
|---|---|---|
| 102 ↗ | (On Diff #23489) | Will do. |
| indent.1 | ||
| 69 ↗ | (On Diff #23489) | Will do. |
Comment Actions
"-P" is OK then.
I can't check easily the length of the lines in phabricator but it's probably fine too as I see longer lines in the original code.
Comment Actions
Approved: however, do remember to add a line
Differential Revision: Revision URL
as the last line in your log.
| indent.c | ||
|---|---|---|
| 101 ↗ | (On Diff #23557) | It is not strictly wrong, as this code has it's own style, but just FYI: Per our style, initialization should be done in line 194, right before profile_name is used. However, this program has an initialization section so it should be there. OTOH, they also do some initializations in the declaration section, so you can leave it there :-P. |