New port: databases/mysqldump-secure
ClosedPublic
Actions

Authored by lifanov on Dec 30 2016, 5:07 PM.

Details

Reviewers

matthew

Commits

rP430268: new port: databases/mysqldump-secure

Summary

Mysqldump-secure is a POSIX compliant open-source backup tool for MySQL databases with strong security in mind. It will backup every available database (which is readable by the specified user) as a separate file with the possibility to opt out via blacklisting.

 PR: 208032
 Submitted by: jsmith@resonatingmedia.com
 Reviewed by: matthew
 Approved by: matthew (mentor)
 Differential revision: https://reviews.freebsd.org/DXXXX

Note (from me):
I had to make a lot of changes to original submission, so I'm still waiting
for submitter feedback about these.

Test Plan

portlint -A - OK
pourdirere testport - OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 6494
Build 6723: arc lint + arc unit

Event Timeline

lifanov updated this revision to Diff 23470.Dec 30 2016, 5:07 PM

lifanov retitled this revision from to New port: databases/mysqldump-secure.

lifanov updated this object.

lifanov edited the test plan for this revision. (Show Details)

lifanov added a reviewer: matthew.

lifanov added a subscriber: koobs.

Herald added a subscriber: mat. · View Herald TranscriptDec 30 2016, 5:07 PM

OK. This looks pretty good to me.

Poudriere is suggesting this is arch independent so you might want to add

NO_ARCH=yes

databases/mysqldump-secure/Makefile
16	USES=mysql adds a LIB_DEPENDS on libmysqlclient.so which doesn't make a lot of sense for a shell script, but it seems it's the only way ${PORTSDIR}/Mk/Uses/mysql.mk provides. That's fairly harmless but a bug: there should be a way of having it produce a RUN_DEPENDS when all you want is the presence of the `mysql` program.
databases/mysqldump-secure/pkg-plist
2–3	Having %%ETCDIR%% as part of a couple of filenames seems counterintuitive. I guess that's what `make makeplist` comes out with though?

lifanov added inline comments.Dec 31 2016, 3:50 AM

databases/mysqldump-secure/Makefile
16	Yeah, it actually needs "mysqldump" which is part of mysql client package(s). I have no idea if there is a better way of depending on this... Is there?
databases/mysqldump-secure/pkg-plist
2–3	Yep, should I expand this?

matthew accepted this revision.Dec 31 2016, 11:50 AM

matthew edited edge metadata.

matthew added inline comments.

databases/mysqldump-secure/Makefile
16	Not really. You want the `USES=mysql` stuff, as that allows choice between the half dozen or so mysql variants.
databases/mysqldump-secure/pkg-plist
2–3	No, on reflection I think it's probably fine as it is.