Paths

Table of Contentst

-
sysutils/mcelog/
-
mcelog/
-
Makefile
-
distinfo

Differential D8957

sysutils/mcelog: Updated to 146
ClosedPublic
Actions

Authored by lifanov on Dec 28 2016, 7:44 PM.

Details

Reviewers

matthew

Commits

rP429939: sysutils/mcelog: Updated to 146

Summary

* Updated to 146
* Added shebangfix

 - Fix malloc buffer overrun for unordered CPUs in sysfs 
 - Fix overriding of DEBUG for make test
 - Change all test scripts to /bin/bash to handle Debian
 - Run all tests in make test

 Bugzilla: 215596
 Submitted by: Ultima1252@gmail.com (maintainer)
 Reviewed by: matthew
 Approved by: matthew (mentor)
 Differential revision: https://reviews.freebsd.org/DXXXX

Test Plan

poudriere testport OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 6437
Build 6668: arc lint + arc unit

Event Timeline

lifanov updated this revision to Diff 23355.Dec 28 2016, 7:44 PM

lifanov retitled this revision from to sysutils/mcelog: Updated to 146.

lifanov updated this object.

lifanov edited the test plan for this revision. (Show Details)

lifanov added a reviewer: matthew.

lifanov added a subscriber: koobs.

Herald added a subscriber: mat. · View Herald TranscriptDec 28 2016, 7:44 PM

lifanov updated this object.Dec 28 2016, 7:59 PM

lifanov updated this object.Dec 28 2016, 8:02 PM

LGTM

This revision is now accepted and ready to land.Dec 29 2016, 8:23 AM

mat added inline comments.Dec 29 2016, 10:16 AM

sysutils/mcelog/Makefile
14	This should be `bash:shells/bash`

address mat's comment: bash dependency should be bash:, not bin/bash:

This revision now requires review to proceed.Dec 29 2016, 2:27 PM

matthew accepted this revision.Dec 29 2016, 2:56 PM

matthew edited edge metadata.

This revision is now accepted and ready to land.Dec 29 2016, 2:56 PM

Closed by commit rP429939: sysutils/mcelog: Updated to 146 (authored by lifanov). · Explain WhyDec 29 2016, 6:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sysutils/

mcelog/

Makefile

10 lines

distinfo

6 lines

Diff 23355

View Options

sysutils/mcelog/Makefile

This file was added.

Property	Old Value	New Value
File Mode	null	100755

				#!/bin/sh

				/usr/bin/sed -i.bak "$@"
				for x in "${@}" ; do
				tobikUnsubmitted Done Inline Actions This script always has exit status 0 which means that the blackbox behavior now differs when DEVELOPER is set and when it is not. If I introduce a syntax error in a sed expression the build will continue unpatched anyway when it probably should abort like before. Maybe add `set -e` or `\|\| exit 1` to the script or handle the error case in some other way. tobik: This script always has exit status 0 which means that the blackbox behavior now differs when…
				swillsAuthorUnsubmitted Done Inline Actions Sure, that's fine. swills: Sure, that's fine.
				if [ -f "${x}" ]; then
				if cmp "${x}" "${x}".bak > /dev/null 2>&1 ; then
				matUnsubmitted Done Inline Actions cmp as a silent mode: if cmp -s "${x}" "${x}".bak ; then mat: cmp as a silent mode: ``` if cmp -s "${x}" "${x}".bak ; then ```
				if [ ! -z "${REWARNFILE}" ]; then
				echo sed failed: backup file same as original: ${x} >> ${REWARNFILE}
				fi
				bdreweryUnsubmitted Done Inline Actions `[ -f $blah ]` doesn't generate output so the redirections aren't needed. bdrewery: `[ -f $blah ]` doesn't generate output so the redirections aren't needed.
				tobikUnsubmitted Done Inline Actions Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR can also be a pretty long path. Would it make sense to strip it like what is done in the shebang and symlink checks in qa.sh? tobik: Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR…
				swillsAuthorUnsubmitted Done Inline Actions Good idea. swills: Good idea.
				fi
				matUnsubmitted Done Inline Actions if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then (or maybe without the `!`, not sure) mat: ``` if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then ``` (or maybe without the `!`, not sure)
				fi
				done
				bdreweryUnsubmitted Not Done Inline Actions You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant with filenames with spaces or globbing characters. Unlikely but trivial to avoid the problem. bdrewery: You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant…