Page MenuHomeFreeBSD

Documentation for discovery-filter.
ClosedPublic

Authored by trasz on Oct 28 2014, 4:13 PM.
Tags
None
Referenced Files
F106102968: D1020.diff
Wed, Dec 25, 11:00 AM
Unknown Object (File)
Tue, Dec 10, 1:04 AM
Unknown Object (File)
Sat, Nov 30, 7:27 AM
Unknown Object (File)
Tue, Nov 26, 12:00 PM
Unknown Object (File)
Nov 20 2024, 12:04 AM
Unknown Object (File)
Nov 19 2024, 11:53 AM
Unknown Object (File)
Oct 12 2024, 8:53 AM
Unknown Object (File)
Oct 9 2024, 3:52 AM
Subscribers

Details

Summary

This is a piece of patch that adds discovery-filter to ctl.conf(5).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

trasz retitled this revision from to Documentation for discovery-filter..
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
trasz added a reviewer: Doc Committers.
bcr added a reviewer: bcr.
bcr added a subscriber: bcr.

Looks good to me.

This revision is now accepted and ready to land.Oct 28 2014, 8:12 PM
wblock added inline comments.
ctl.conf.5
205 ↗(On Diff #2135)

I would prefer to break this long sentence.

and authentication credentials.
That is, if the target does not require CHAP authentication, or if CHAP user and secret are used during discovery, both CHAP user and secret are required to match to access the target.

ctl.conf.5
205 ↗(On Diff #2135)

Hm, that's not quite what I meant. What I'm trying to say is, the access will be allowed if 1. target doesn't require authentication, or 2. target does require it, and authentication credentials during discovery match those of the target.

ctl.conf.5
205 ↗(On Diff #2135)

That is a much clearer statement. Maybe:

and authentication credentials.
Access to the target is allowed if the target does not require CHAP authentication.
If authentication is required, CHAP user and secret must be supplied and match those used during discovery.

ctl.conf.5
205 ↗(On Diff #2135)

I'm not sure if I'd understand this correctly if I didn't already know what it does.

How about this:

The target will be returned if it doesn't require CHAP authentication, or if CHAP user and secret used during discovery match those of the target.

ctl.conf.5
205 ↗(On Diff #2135)

Minor adjustment:

The target is returned if it does not require CHAP authentication, or if the CHAP user and secret used during discovery match those used by the target.

trasz updated this revision to Diff 2331.

Closed by commit rS274278 (authored by @trasz).