Page MenuHomeFreeBSD
Differential D8919

USES=samba
ClosedPublic
Actions

Authored by antoine on Dec 26 2016, 9:00 PM.
Tags
None
Referenced Files
F151355298: D8919.diff
Tue, Apr 7, 8:39 PM
F151265340: D8919.id26061.diff
Tue, Apr 7, 5:03 AM
Unknown Object (File)
Mon, Apr 6, 9:13 AM
Unknown Object (File)
Mon, Apr 6, 2:16 AM
Unknown Object (File)
Sun, Apr 5, 11:21 AM
Unknown Object (File)
Mon, Mar 30, 12:28 AM
Unknown Object (File)
Sun, Mar 29, 3:54 PM
Unknown Object (File)
Sun, Mar 29, 3:19 PM
View All Files
Subscribers
mat

Details

Reviewers
mat
Group Reviewers
portmgr
Commits
rP436659: - Add USES=samba to handle dependency on samba
Summary

USES=samba, this is totally untested and just a draft for now

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6397
Build 6630: arc lint + arc unit

Event Timeline

antoine updated this revision to Diff 23286.Dec 26 2016, 9:00 PM
antoine retitled this revision from to USES=samba.
antoine updated this object.
antoine edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptDec 26 2016, 9:00 PM
Herald added a subscriber: mat. · View Herald Transcript
mat added inline comments.Dec 27 2016, 9:28 AM
Mk/Uses/samba.mk
5–7

maybe there could be a default, say, build run

25

This may need a .else IGNORE=invalid samba version or check-makevars:: or something.

antoine updated this revision to Diff 23297.Dec 27 2016, 3:37 PM
antoine edited edge metadata.

Convert a few ports

Herald edited edge metadata. · View Herald TranscriptDec 27 2016, 3:37 PM
mat added a comment.Jan 4 2017, 4:28 PM

This looks promising :-)

antoine updated this revision to Diff 26061.Mar 7 2017, 11:38 AM
antoine edited edge metadata.

This version should be ready for review/exp-run

Herald edited edge metadata. · View Herald TranscriptMar 7 2017, 11:38 AM
mat added inline comments.Mar 8 2017, 12:55 PM
multimedia/kodi/Makefile
139 ↗(On Diff #26061)

I don't think lib,run makes a lot of sense, lib is already build+run.

antoine updated this revision to Diff 26132.Mar 10 2017, 9:24 PM

Don't use lib,run

mat accepted this revision.Mar 13 2017, 4:29 PM

Looks good to me, time to exp-run and test that pkg upgrade works ?

This revision is now accepted and ready to land.Mar 13 2017, 4:29 PM
antoine closed this revision.Mar 21 2017, 10:06 PM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
38 lines
2 lines
net/
samba42/
1 line
3 lines
samba43/
1 line
3 lines
samba44/
1 line
3 lines

Diff 23286

View Options

Mk/Uses/samba.mk

Loading...
View Options

Mk/bsd.default-versions.mk

Loading...
View Options

net/samba42/Makefile

Loading...
View Options

net/samba42/pkg-plist

Loading...
View Options

net/samba43/Makefile

Loading...
View Options

net/samba43/pkg-plist

Loading...
View Options

net/samba44/Makefile

Loading...
View Options

net/samba44/pkg-plist

Loading...