MCA: Don't refill the record list during boot.
ClosedPublic
Actions

Authored by markj on Dec 14 2016, 12:06 AM.

Tags

None

Referenced Files

	F110309814: D8783.id22924.diff
	Sun, Feb 16, 2:57 PM

	Unknown Object (File)
	Fri, Jan 31, 4:14 PM

	Unknown Object (File)
	Thu, Jan 30, 6:03 PM

	Unknown Object (File)
	Mon, Jan 27, 6:12 AM

	Unknown Object (File)
	Fri, Jan 24, 4:47 PM

	Unknown Object (File)
	Wed, Jan 22, 10:13 PM

	Unknown Object (File)
	Wed, Jan 22, 10:09 PM

	Unknown Object (File)
	Wed, Jan 22, 10:02 PM

View All 39 Files

Subscribers

None

Details

Reviewers

cem
jhb

Commits

rS310084: Don't run the MCA record refill task during boot.

Summary

If we take a CMCI during boot (between SI_SUB_CPU and SI_SUB_CONFIGURE)
before the refill task is initialized, we'll panic otherwise. Instead, predicate use of
the taskqueue on !cold and make sure that we've refilled the record list when starting
the taskqueue thread.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6229
Build 6472: arc lint + arc unit

Event Timeline

markj updated this revision to Diff 22895.Dec 14 2016, 12:06 AM

markj retitled this revision from to MCA: Don't refill the record list during boot..

markj edited the test plan for this revision. (Show Details)

markj updated this object.

markj updated this object.Dec 14 2016, 12:12 AM

markj added reviewers: cem, jhb.

cem accepted this revision.Dec 14 2016, 1:16 AM

cem edited edge metadata.

This revision is now accepted and ready to land.Dec 14 2016, 1:16 AM

(Rough life if you are getting CMCI's before you can even get to single user)

sys/x86/x86/mca.c
717	Blank line before comment.

Closed by commit rS310084: Don't run the MCA record refill task during boot. (authored by markj). · Explain WhyDec 14 2016, 7:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

x86/

mca.c

4 lines

Diff 22895

View Options

MCA: Don't refill the record list during boot.ClosedPublicActions