Fix the stale and incorrect comments in vm/default_pager.c
ClosedPublic
Actions

Authored by alc on Dec 13 2016, 6:57 PM.

Details

Reviewers

kib
markj

Commits

rS310083: Tidy up. Mostly, remove or replace stale comments. Most of the comments

Summary

This seems like a classic case of misplaced comments: Comments in place X describe what is going on in place Y. As place Y evolves, no one expects that there are comments elsewhere describing how place Y works.

I've also addressed some style issues.

Test Plan

Tell me if you think that I've actually deleted anything useful.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

alc updated this revision to Diff 22887.Dec 13 2016, 6:57 PM

alc retitled this revision from to Fix the stale and incorrect comments in vm/default_pager.c.

alc updated this object.

alc edited the test plan for this revision. (Show Details)

alc added reviewers: markj, kib.

kib accepted this revision.Dec 13 2016, 7:02 PM

kib edited edge metadata.

This revision is now accepted and ready to land.Dec 13 2016, 7:02 PM

alc added inline comments.Dec 13 2016, 7:03 PM

vm/default_pager.c
117	I'm thinking of changing "this method will" to "this method implementation will".

kib added inline comments.Dec 13 2016, 7:24 PM

vm/default_pager.c
117	In my previous life, where I programmed e.g. in C++, I do not remember a need to use extra-accurate and long 'this method implementation' designator when the reference was obviously to the current implementation.