Page MenuHomeFreeBSD
Differential D8700

Use ${PKG_BIN} instead of hard-coded pkg command
ClosedPublic
Actions

Authored by tgyurci_gmail.com on Dec 3 2016, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 21, 12:45 PM
Unknown Object (File)
Tue, Oct 21, 12:45 PM
Unknown Object (File)
Tue, Oct 21, 12:45 PM
Unknown Object (File)
Tue, Oct 21, 12:45 PM
Unknown Object (File)
Tue, Oct 21, 12:45 PM
Unknown Object (File)
Tue, Oct 21, 1:03 AM
Unknown Object (File)
Mon, Oct 13, 6:13 AM
Unknown Object (File)
Tue, Sep 30, 8:02 AM
View All 86 Files
Subscribers
mat
Contributor Reviewers (ports)

Details

Reviewers
bapt
mat
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP542782: Use macro PKG_QUERY instead of hardcoded pkg query

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6136
Build 6392: arc lint + arc unit

Event Timeline

tgyurci_gmail.com updated this revision to Diff 22687.Dec 3 2016, 10:42 PM
tgyurci_gmail.com retitled this revision from to Use ${PKG_BIN} instead of hard-coded pkg command.
tgyurci_gmail.com updated this object.
tgyurci_gmail.com edited the test plan for this revision. (Show Details)
tgyurci_gmail.com set the repository for this revision to rP FreeBSD ports repository.
Owners added a reviewer: O5: Ports Framework.Dec 3 2016, 10:42 PM
Herald added a reviewer: portmgr. · View Herald TranscriptDec 3 2016, 10:42 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald Transcript
bapt accepted this revision.Dec 3 2016, 11:04 PM
bapt added a reviewer: bapt.
mat requested changes to this revision.Dec 4 2016, 12:33 AM
mat added a reviewer: mat.
mat added inline comments.
Scripts/qa.sh
12–16

This is not needed, the only possible usage of this script is through b.ports.m and it has the required environment variable.

This revision now requires changes to proceed.Dec 4 2016, 12:33 AM
tgyurci_gmail.com updated this revision to Diff 22697.Dec 4 2016, 7:11 AM
tgyurci_gmail.com edited edge metadata.

I removed PKG_BIN from QA_ENV too

tgyurci_gmail.com updated this revision to Diff 22718.Dec 5 2016, 3:28 PM
tgyurci_gmail.com edited edge metadata.

PKG_BIN should be in QA_ENV for qa.sh.

tgyurci_gmail.com marked an inline comment as done.Dec 5 2016, 9:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2020, 7:16 PM
Closed by commit rP542782: Use macro PKG_QUERY instead of hardcoded pkg query (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rP542782: Use macro PKG_QUERY instead of hardcoded pkg query.

Revision Contents
Changeset List

PathSize
Scripts/
6 lines
Uses/
2 lines

Diff 22697

View Options

Scripts/qa.sh

Loading...
View Options

Uses/ncurses.mk

Loading...