Differential D1105

Implement ppoll() system call.
ClosedPublic
Actions

Authored by dchagin on Nov 4 2014, 4:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 30, 10:26 AM

	Unknown Object (File)
	Fri, Apr 26, 7:56 AM

	Unknown Object (File)
	Fri, Apr 26, 7:56 AM

	Unknown Object (File)
	Fri, Apr 26, 7:56 AM

	Unknown Object (File)
	Fri, Apr 26, 7:56 AM

	Unknown Object (File)
	Fri, Apr 26, 7:56 AM

	Unknown Object (File)
	Fri, Apr 26, 12:23 AM

	Unknown Object (File)
	Tue, Apr 23, 9:54 AM

Subscribers

Details

Reviewers

Group Reviewers

Linux Emulation

Commits

rS283451: Implement ppoll() system call.

Summary

(need more test, ltp passed)

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2267.Nov 4 2014, 4:14 PM

dchagin retitled this revision from to Implement ppoll() system call..

dchagin updated this object.

dchagin added a reviewer: Linux Emulation.Nov 4 2014, 5:44 PM

trasz added a subscriber: trasz.Dec 8 2014, 11:09 AM

trasz added inline comments.

sys/amd64/linux/syscalls.master
458	Misplaced space, should be "struct pollfd *fds".
sys/compat/linux/linux_misc.c
2189	if (args->sset != NULL) {
2197	Why call SIGDELSET? A comment would be nice.
2201	if (args->tsp != NULL) {

Fixed, thanks! btw, also for all of Linuxulator's sigprocmask syscall family should be remove SIGKILL|SIGSTOP from new signal mask.
Will be fixed soon.

whoops, kern_sigprocmask() already call SIG_CANTMASK for new mask, so remove my SIGDELSET.

trasz added inline comments.Mar 21 2015, 5:18 PM

sys/compat/linux/linux_misc.c
2213	What is this for? The sys_poll() implementation doesn't seem to do anything like this.

dchagin added inline comments.Mar 24 2015, 6:24 PM

sys/compat/linux/linux_misc.c
2213	The Linux ppoll() system call modifies its timeout argument.

trasz accepted this revision.Mar 25 2015, 11:21 AM

trasz added a reviewer: trasz.

trasz added inline comments.

sys/compat/linux/linux_misc.c
2213	A comment explaining this would be nice. Still, looks ok.

This revision is now accepted and ready to land.Mar 25 2015, 11:21 AM

Closed by commit rS283451: Implement ppoll() system call. (authored by dchagin). · Explain WhyMay 24 2015, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

linux/

1 line

syscalls.master

3 lines

linux32/

linux32_dummy.c

1 line

syscalls.master

3 lines

compat/

linux/

55 lines

i386/

linux/

1 line

syscalls.master

3 lines

Diff 2267

sys/amd64/linux/linux_dummy.c

Loading...

sys/amd64/linux/syscalls.master

Loading...

sys/amd64/linux32/linux32_dummy.c

Loading...

sys/amd64/linux32/syscalls.master

Loading...

sys/compat/linux/linux_misc.c

Loading...

sys/i386/linux/linux_dummy.c

Loading...

sys/i386/linux/syscalls.master

Loading...