Page MenuHomeFreeBSD
Differential D8626

Add -E option to nfsstat
ClosedPublic
Actions

Authored by rmacklem on Nov 23 2016, 11:11 PM.
Tags
None
Referenced Files
F85435516: D8626.id22472.diff
Thu, Jun 6, 1:12 AM
Unknown Object (File)
Fri, May 24, 9:18 PM
Unknown Object (File)
Thu, May 23, 4:36 PM
Unknown Object (File)
Mon, May 13, 3:28 PM
Unknown Object (File)
Apr 20 2024, 2:35 PM
Unknown Object (File)
Apr 20 2024, 2:04 PM
Unknown Object (File)
Mar 20 2024, 7:28 AM
Unknown Object (File)
Dec 27 2023, 7:43 PM
View All 57 Files
Subscribers
bcr

Details

Reviewers
bcr
Commits
rS309198: Document the -E flag for nfsstat.
rS309197: Add a -E flag to nfsstat.c so that it prints out the NFSv4.1
Summary

This patch adds a -E option to nfsstat so that it displays statistics that include NFSv4.1.
It is similar to the -e option for displaying NFSv4.0 statistics. It also does not clip the
numbers at 1 billion.

Test Plan

Tested for both client and server running an NFSv4.1 mount.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rmacklem updated this revision to Diff 22472.Nov 23 2016, 11:11 PM
rmacklem retitled this revision from to Add -E option to nfsstat.
rmacklem updated this object.
rmacklem edited the test plan for this revision. (Show Details)
bcr added a subscriber: bcr.Nov 24 2016, 7:27 AM

A few textual suggestions, the man page looks fine to me.
I look forward to testing that change.

usr.bin/nfsstat/nfsstat.c
214 ↗(On Diff #22472)

I think it would sound better as "... are mutually exclusive". Same for the other error message.

830 ↗(On Diff #22472)

I would capitalize RPC

rmacklem updated this revision to Diff 22484.Nov 24 2016, 11:50 PM

Changes suggested by bcr@ have been applied to the patch.

rmacklem added a reviewer: bcr.Nov 24 2016, 11:51 PM

Maybe you'd like to review this, now that I have applied your suggested changes.

Thanks, rick

bcr edited edge metadata.Nov 25 2016, 7:14 AM

Hi Rick,
thanks for making the changes. Unfortunately, I'm not a src committer, so I can review it to a certain degree, but can't approve without the missing bit. ;-)

bcr added a comment.Nov 26 2016, 11:18 AM

You could commit it with Reviewed by: bcr (doc parts). That way, people know what I reviewed. Thanks!

Closed by commit rS309197: Add a -E flag to nfsstat.c so that it prints out the NFSv4.1 (authored by rmacklem). · Explain WhyNov 26 2016, 8:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.bin/
nfsstat/
370 lines

Diff 22531

View Options

head/usr.bin/nfsstat/nfsstat.c

Loading...