Add -E option to nfsstat
ClosedPublic
Actions

Authored by rmacklem on Nov 23 2016, 11:11 PM.

Details

Reviewers

Commits

rS309198: Document the -E flag for nfsstat.
rS309197: Add a -E flag to nfsstat.c so that it prints out the NFSv4.1

Summary

This patch adds a -E option to nfsstat so that it displays statistics that include NFSv4.1.
It is similar to the -e option for displaying NFSv4.0 statistics. It also does not clip the
numbers at 1 billion.

Test Plan

Tested for both client and server running an NFSv4.1 mount.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rmacklem updated this revision to Diff 22472.Nov 23 2016, 11:11 PM

rmacklem retitled this revision from to Add -E option to nfsstat.

rmacklem updated this object.

rmacklem edited the test plan for this revision. (Show Details)

A few textual suggestions, the man page looks fine to me.
I look forward to testing that change.

usr.bin/nfsstat/nfsstat.c
214	I think it would sound better as "... are mutually exclusive". Same for the other error message.
830	I would capitalize RPC

Changes suggested by bcr@ have been applied to the patch.

Maybe you'd like to review this, now that I have applied your suggested changes.

Thanks, rick

Hi Rick,
thanks for making the changes. Unfortunately, I'm not a src committer, so I can review it to a certain degree, but can't approve without the missing bit. ;-)

You could commit it with Reviewed by: bcr (doc parts). That way, people know what I reviewed. Thanks!

Closed by commit rS309197: Add a -E flag to nfsstat.c so that it prints out the NFSv4.1 (authored by rmacklem). · Explain WhyNov 26 2016, 8:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

nfsstat/

	nfsstat.1
	nfsstat.1.newsav

14 lines

	nfsstat.c
	nfsstat.c.newsav

370 lines

Diff 22472

View Options

usr.bin/nfsstat/nfsstat.1