Page MenuHomeFreeBSD
Differential D8626

Add -E option to nfsstat
ClosedPublic
Actions

Authored by rmacklem on Nov 23 2016, 11:11 PM.
Tags
None
Referenced Files
F106648354: D8626.diff
Fri, Jan 3, 8:30 AM
Unknown Object (File)
Nov 21 2024, 4:31 PM
Unknown Object (File)
Oct 1 2024, 2:05 PM
Unknown Object (File)
Oct 1 2024, 1:55 PM
Unknown Object (File)
Sep 26 2024, 4:52 PM
Unknown Object (File)
Sep 17 2024, 1:55 PM
Unknown Object (File)
Sep 8 2024, 10:18 PM
Unknown Object (File)
Sep 8 2024, 8:25 AM
View All 74 Files
Subscribers
bcr

Details

Reviewers
bcr
Commits
rS309198: Document the -E flag for nfsstat.
rS309197: Add a -E flag to nfsstat.c so that it prints out the NFSv4.1
Summary

This patch adds a -E option to nfsstat so that it displays statistics that include NFSv4.1.
It is similar to the -e option for displaying NFSv4.0 statistics. It also does not clip the
numbers at 1 billion.

Test Plan

Tested for both client and server running an NFSv4.1 mount.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rmacklem updated this revision to Diff 22472.Nov 23 2016, 11:11 PM
rmacklem retitled this revision from to Add -E option to nfsstat.
rmacklem updated this object.
rmacklem edited the test plan for this revision. (Show Details)
bcr added a subscriber: bcr.Nov 24 2016, 7:27 AM

A few textual suggestions, the man page looks fine to me.
I look forward to testing that change.

usr.bin/nfsstat/nfsstat.c
214

I think it would sound better as "... are mutually exclusive". Same for the other error message.

830

I would capitalize RPC

rmacklem updated this revision to Diff 22484.Nov 24 2016, 11:50 PM

Changes suggested by bcr@ have been applied to the patch.

rmacklem added a reviewer: bcr.Nov 24 2016, 11:51 PM

Maybe you'd like to review this, now that I have applied your suggested changes.

Thanks, rick

bcr edited edge metadata.Nov 25 2016, 7:14 AM

Hi Rick,
thanks for making the changes. Unfortunately, I'm not a src committer, so I can review it to a certain degree, but can't approve without the missing bit. ;-)

bcr added a comment.Nov 26 2016, 11:18 AM

You could commit it with Reviewed by: bcr (doc parts). That way, people know what I reviewed. Thanks!

Closed by commit rS309197: Add a -E flag to nfsstat.c so that it prints out the NFSv4.1 (authored by rmacklem). · Explain WhyNov 26 2016, 8:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
nfsstat/
nfsstat.c
nfsstat.1.newsav
1466 lines
nfsstat.c
nfsstat.c.newsav
372 lines

Diff 22484

View Options

usr.bin/nfsstat/nfsstat.c

Loading...
View Options

usr.bin/nfsstat/nfsstat.c

Loading...