biology/njplot: Revive and upgrade to version 2.4
ClosedPublic
Actions

Authored by jrm on Nov 15 2016, 1:15 AM.

Details

Reviewers

swills
AMDmi3

Commits

rP426241: biology/njplot: Revive and update to version 2.4

Summary

biology/njplot: Revive and upgrade to version 2.4

Test Plan

portlint -C: OK
testport: OK (poudriere: 9.3-RELEASE-p48, i386, default options)
testport: OK (poudriere: 9.3-RELEASE-p48, amd64, default options)
testport: OK (poudriere: 10.3-RELEASE-p10, i386, default options)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, i386, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64, default options)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 5955
Build 6236: arc lint + arc unit

Event Timeline

jrm updated this revision to Diff 22203.Nov 15 2016, 1:15 AM

jrm retitled this revision from to biology/njplot: Revive and upgrade to version 2.4.

jrm updated this object.

jrm edited the test plan for this revision. (Show Details)

jrm added reviewers: swills, AMDmi3.

Herald added a subscriber: mat. · View Herald TranscriptNov 15 2016, 1:15 AM

Also I'd change MAN_1 and BINARIES stuff into explicit installation:

do-install:
    ${INSTALL_PROGRAM} ${WRKSRC}/newicktops ${WRKSRC}/newicktotxt ${STAGEDIR}${PREFIX}/bin
    ${INSTALL_MAN} ${WRKSRC}/*.1 ${STAGEDIR}${MANPREFIX}/man/man1

do-install-X11-on:
    ${INSTALL_PROGRAM} ${WRKSRC}/njplot ${WRKSRC}/unrooted ${STAGEDIR}${PREFIX}/bin

it's shorter and cleaner that way.

And finally, X11 option doesn't seem consistent. It's strange that njplot port may not install njplot binary, and it's strange that nhplot help file and documentation are installed even if the binary isn't. I'd drop the option completely, and, if newicktops newicktotxt are actually usable separately, move them into separate port.

biology/njplot/Makefile
7–8	It may be useful to leave ftp://pbil.univ-lyon1.fr/pub/mol_phylogeny/njplot/archive/ as a secondary MASTER_SITE, so if current version if moved to archive, it won't break fetch.
22–25	LICENSE= NONE
26–27	@
27	We don't list DOCS, EXAMPLES and NLS in OPTIONS_DEFAULT.
30	I'd prefer uppercase XORG= for consistency (it's USE_XORG, not USE_xorg)
30–31	MANPREFIX
31–37	INSTALL_DATA. Docs are not manpages.
biology/njplot/files/patch-makefile
6	First, slash seems to be missing after ${DOCSDIR}. Next, it looks like a help file which is always used by the program, not additional documentation, so I'd move it into DATADIR and install unconditionally.
15	Should stay "?=" to respect CC.