Differential D8523

Reduce NFS "> 32bit" dmesg spam
ClosedPublic
Actions

Authored by cperciva on Nov 15 2016, 6:58 AM.

Details

Reviewers

rmacklem

Commits

rS308708: Reduce NFS "NFSv4( mounted on)? fileid > 32bits" log spam.

Summary

This changes the current behaviour of printing a line of output for every NFS fileid >= 2^32 to aggregating, e.g.,

Nov 15 05:17:34 ip-172-30-1-221 kernel: NFSv4 fileid > 32bits (24730 occurrences)
Nov 15 05:17:56 ip-172-30-1-221 kernel: NFSv4 mounted on fileid > 32bits (178 occurrences)
Nov 15 05:18:53 ip-172-30-1-221 kernel: NFSv4 fileid > 32bits (7582 occurrences)
Nov 15 05:18:58 ip-172-30-1-221 kernel: NFSv4 mounted on fileid > 32bits (23 occurrences)

A buildworld on an NFS mounted /usr/obj can otherwise result in hundreds of thousands of lines being printed.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cperciva updated this revision to Diff 22210.Nov 15 2016, 6:58 AM

cperciva retitled this revision from to Reduce NFS "> 32bit" dmesg spam.

cperciva updated this object.

cperciva edited the test plan for this revision. (Show Details)

cperciva added a reviewer: rmacklem.

This looks fine to me. In the commit log message, please mention that this needs to
be fixed by increasing ino_t to 64bits, so this printf can go away.

Thanks, rick

This revision is now accepted and ready to land.Nov 15 2016, 11:28 PM

Closed by commit rS308708: Reduce NFS "NFSv4( mounted on)? fileid > 32bits" log spam. (authored by cperciva). · Explain WhyNov 16 2016, 1:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfs/

nfs_commonsubs.c

26 lines

Diff 22210

View Options

sys/fs/nfs/nfs_commonsubs.c

Reduce NFS "> 32bit" dmesg spamClosedPublicActions