Differential D1073

Refund the proc emuldata struct for future use. For now move flags from thread emuldata to proc emuldata as it was originally intended.
ClosedPublic
Actions

Authored by dchagin on Nov 1 2014, 2:17 PM.

Details

Reviewers

None

Group Reviewers

Linux Emulation

Commits

rS283422: Refund the proc emuldata struct for future use. For now move flags from

Summary

As we can have both 64 & 32 bit Linuxulator running any eventhandler
can be called twice for us. To prevent this move eventhandlers code
from linux_emul.c to the linux_common.ko module.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2212.Nov 1 2014, 2:17 PM

dchagin retitled this revision from to Refund the proc emuldata struct for future use. For now move flags from thread emuldata to proc emuldata as it was originally intended..

dchagin updated this object.

Updating D1073: Refund the proc emuldata struct for future use. For now move flags from

thread emuldata to proc emuldata as it was originally intended.

Enter a brief description of the changes included in this update.
The first line is used as subject, next lines as comment. #

Like D1072

dchagin added a reviewer: Linux Emulation.Nov 2 2014, 9:37 PM

trasz added a subscriber: trasz.Mar 27 2015, 10:22 AM

trasz added inline comments.

sys/compat/linux/linux_emul.c
91	Might be a good idea to convert this and pem to use UMA instead of malloc. But that's for a later commit.
223	I'd suggest moving this (sx_destroy and free) to a new function, pem_free().
sys/compat/linux/linux_fork.c
456	suword32(9) instead, perhaps?
472	linux_msg() instead of printf()?