Page MenuHomeFreeBSD
Differential D8467

Userland PQ_LAUNDRY support
ClosedPublic
Actions

Authored by markj on Nov 7 2016, 5:53 PM.
Tags
None
Referenced Files
F106625008: D8467.diff
Thu, Jan 2, 10:38 PM
Unknown Object (File)
Fri, Dec 27, 5:23 AM
Unknown Object (File)
Thu, Dec 26, 7:18 AM
Unknown Object (File)
Wed, Dec 25, 10:37 AM
Unknown Object (File)
Wed, Dec 25, 10:34 AM
Unknown Object (File)
Wed, Dec 25, 10:33 AM
Unknown Object (File)
Wed, Dec 25, 10:28 AM
Unknown Object (File)
Wed, Dec 25, 10:21 AM
View All Files
Subscribers
None

Details

Reviewers
kib
alc
Commits
rS308489: Add the laundry page count to the displays of systat, top, and vmstat.
Summary

This consists of modifications to systat, vmstat and top. Generally, I
replaced v_cache_count, which is now always zero, with v_laundry_count.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5877
Build 6164: arc lint + arc unit

Event Timeline

markj updated this revision to Diff 22062.Nov 7 2016, 5:53 PM
markj retitled this revision from to Userland PQ_LAUNDRY support.
markj edited the test plan for this revision. (Show Details)
markj updated this object.
markj added a reviewer: alc.Nov 7 2016, 5:55 PM
alc added a reviewer: kib.Nov 9 2016, 6:53 PM
alc added inline comments.Nov 9 2016, 11:09 PM
usr.bin/systat/systat.1
414

I think that it's worth having the word "dirty" here. Maybe "dirty pages queued for laundering"?

alc added inline comments.Nov 9 2016, 11:14 PM
usr.bin/top/top.local.1
29

Maybe "queued for laundering" instead of "inactive"?

kib accepted this revision.Nov 10 2016, 5:46 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2016, 5:46 PM
markj updated this revision to Diff 22131.Nov 10 2016, 7:33 PM
markj edited edge metadata.

review fixups

This revision now requires review to proceed.Nov 10 2016, 7:33 PM
alc accepted this revision.Nov 10 2016, 7:38 PM
alc edited edge metadata.
This revision is now accepted and ready to land.Nov 10 2016, 7:38 PM
Closed by commit rS308489: Add the laundry page count to the displays of systat, top, and vmstat. (authored by markj). · Explain WhyNov 10 2016, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
systat/
4 lines
10 lines
top/
6 lines
13 lines
vmstat/
12 lines

Diff 22062

View Options

usr.bin/systat/systat.1

Loading...
View Options

usr.bin/systat/vmstat.c

Loading...
View Options

usr.bin/top/machine.c

Loading...
View Options

usr.bin/top/top.local.1

Loading...
View Options

usr.bin/vmstat/vmstat.c

Loading...