poudriere(8) link in "Building Packages with Poudriere" doesn't point to a valid manpage
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
The only item I wanted in this review was this patch:
en_US.ISO8859-1/books/handbook/ports/chapter.xml
Somehow previous ones are sneaking in....
Comment Actions
Only en_US.ISO8859-1/books/handbook/ports/chapter.xml reviewed.
| en_US.ISO8859-1/books/handbook/ports/chapter.xml | ||
|---|---|---|
| 1716 | Avoid using "you", and the markup identifies a package: "after installing <package>ports-mgmt/poudriere</package>" | |
Comment Actions
There seems to be a space missing here:
details once you have installed the software package<package> ports-mgmt/poudriere</package> or <package> ports-mgmt/poudriere-devel</package>.</para>
The first line, after package, there should be a space.
However, we have multiple references to software that is not installed yet. I am not too shavvy that we need to add more words around that because then we need to do that allover.
I like the other changes :)
Remko
Comment Actions
I would lean towards "after" rather than "once", because "once" has multiple meanings ("after", and "one time"). But it is probably okay here.