Page MenuHomeFreeBSD
Differential D8386

New port, math/amath: simple command line calculator
ClosedPublic
Actions

Authored by jrm on Oct 30 2016, 11:08 PM.
Tags
None
Referenced Files
F103132311: D8386.diff
Thu, Nov 21, 10:34 AM
Unknown Object (File)
Mon, Nov 18, 7:47 PM
Unknown Object (File)
Tue, Nov 12, 10:53 PM
Unknown Object (File)
Mon, Nov 11, 5:31 AM
Unknown Object (File)
Tue, Oct 29, 2:10 PM
Unknown Object (File)
Oct 3 2024, 6:23 AM
Unknown Object (File)
Oct 1 2024, 2:07 PM
Unknown Object (File)
Oct 1 2024, 12:56 PM
View All Files
Subscribers
mat

Details

Reviewers
swills
AMDmi3
Commits
rP425086: New port, math/amath: simple command line calculator
Summary

New port, math/amath: simple command line calculator

Features a case sensitive command line interface, internal IEEE 754
calculations with 15 significant digits, calculations with real and
complex numbers, variables and user defined functions, logarithmic
and exponential functions, trigonometric and hyperbolic function
and selected mathematical constants and rounding functions.

Test Plan

portlint -AC: OK
testport: OK (poudriere: 9.3-RELEASE-p48, i386)
testport: OK (poudriere: 9.3-RELEASE-p48, amd64)
testport: OK (poudriere: 10.3-RELEASE-p10, i386)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64)
testport: OK (poudriere: 11.0-RELEASE-p1, i386)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm updated this revision to Diff 21811.Oct 30 2016, 11:08 PM
jrm retitled this revision from to New port, math/amath: simple command line calculator.
jrm updated this object.
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: swills, AMDmi3.
Herald added a subscriber: mat. · View Herald TranscriptOct 30 2016, 11:08 PM
mat added inline comments.Oct 31 2016, 4:58 PM
math/amath/Makefile
18 ↗(On Diff #21811)

I don't think anything warrants creating a variable for only one use :-)

20–22 ↗(On Diff #21811)

This can be replaced by:

MAKE_ARGS=CC=${CC}
27 ↗(On Diff #21811)
do-test:
jrm updated this revision to Diff 21842.Oct 31 2016, 6:10 PM

Update with suggestions from mat:

  • Don't create extra variable, but reuse ${PORTNAME}.
  • Don't patch Makefile to work around hardcoded CC=gcc, but set MAKE_ARGS.
  • Use do-test target instead of regression-test.
swills accepted this revision.Nov 1 2016, 7:16 PM
swills edited edge metadata.

Approved

This revision is now accepted and ready to land.Nov 1 2016, 7:16 PM
Closed by commit rP425086: New port, math/amath: simple command line calculator (authored by jrm). · Explain WhyNov 1 2016, 8:27 PM
This revision was automatically updated to reflect the committed changes.
jrm marked 3 inline comments as done.

Revision Contents
Changeset List

PathSize
head/
math/
1 line
amath/
25 lines
3 lines
7 lines

Diff 21911

View Options

head/math/Makefile

Loading...
View Options

head/math/amath/Makefile

Loading...
View Options

head/math/amath/distinfo

Loading...
View Options

head/math/amath/pkg-descr

Loading...