Page MenuHomeFreeBSD

New port, sysutils/zfs-snap-diff: View ZFS snapshot differences in a web browser
ClosedPublic

Authored by jrm on Oct 31 2016, 1:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 3:02 AM
Unknown Object (File)
Mon, Oct 28, 8:41 PM
Unknown Object (File)
Oct 24 2024, 3:33 PM
Unknown Object (File)
Oct 21 2024, 1:11 PM
Unknown Object (File)
Oct 3 2024, 10:03 PM
Unknown Object (File)
Oct 1 2024, 11:42 AM
Unknown Object (File)
Sep 30 2024, 11:22 PM
Unknown Object (File)
Sep 23 2024, 7:32 AM
Subscribers

Details

Summary

New port, sysutils/zfs-snap-diff: View ZFS snapshot differences in a web browser

https://github.com/j-keck/zfs-snap-diff

Test Plan

portlint -C: OK
testport: OK (poudriere: 9.3-RELEASE-p48, i386)
testport: OK (poudriere: 9.3-RELEASE-p48, amd64)
testport: OK (poudriere: 10.3-RELEASE-p10, i386)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64)
testport: OK (poudriere: 11.0-RELEASE-p1, i386)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5766
Build 6070: arc lint + arc unit

Event Timeline

jrm retitled this revision from to New port, sysutils/zfs-snap-diff: View ZFS snapshot differences in a web browser.
jrm updated this object.
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: swills, AMDmi3.
sysutils/zfs-snap-diff/Makefile
7

I'm not sure something warrants using DIST_SUBDIR here, distfiles come from github, so they are already versionned.

30–40

This should be:

GH_SUBDIR= src/github.com/j-keck/zfs-snap-diff  src/github.com/sergi/go-diff:go_diff
42–49

I wonder if these are not automatically done by USES=go.

Incorporate suggestions from mat and use latest go-diff GitHub commit.

  • Do not define DIST_SUBDIR.
  • Replace post-extract target by defining GH_SUBDIR.
  • Replace BUILD_DEPENDS=, and do-build and do-install targets with USES=go.
jrm marked an inline comment as done.Oct 31 2016, 6:50 PM
jrm added inline comments.
sysutils/zfs-snap-diff/Makefile
7

DIST_SUBDIR is still here! Fixing...

Really remove DIST_SUBDIR this time.

swills edited edge metadata.

Approved

This revision is now accepted and ready to land.Nov 1 2016, 7:04 PM
This revision was automatically updated to reflect the committed changes.
jrm marked 3 inline comments as done.