Paths

Table of Contentst

Differential D8339

lang/mono: update to 4.6.1.5 (and update related ports)
ClosedPublic
Actions

Authored by dbn on Oct 26 2016, 5:14 AM.

Details

Reviewers

mat

Group Reviewers

portmgr

Commits

rP424974: lang/mono: update to 4.6.1.5.

Summary

@mat: since I am making changes to USES=mono, please check.

"Commit" log:

lang/mono: update to 4.6.1.5.

USES=mono: add nuget argument

The nuget argument adds support for nuget packages.  The nuget
packages must be specified in the NUGET_DEPENDS variable.

devel/monodevelop: update to 6.1.1.15

Switch to github. The other official source is quite a few versions behind.
Add missing dependencies (fsharp, ssl2, curl)
Add required nuget packages
Add required external repositories
Drop options. Although ./configure offers these flags, there is no functional change (i.e. no-op)
All patches have been upstreamed (and the one we need is from upstream).

lang/fsharp: update to 4.0.1.15

convert to use the nuget argument. ChangeLog:
- Fix null condition in Fsc task

lang/mono-devel: update to 4.6

switch to new test target (currently tests the port to be installed)

www/gecko-sharp20: depreciate: broken and no-upstream

Give 1 month for anyone to complain that this port is being removed.

x11-toolkits/gtk-sharp30: bump PORTREVISION

Add LICENSE information
Add missing dependencies (per stage-qa)

x11-toolkits/gtk-sharp20: update to 2.12.40.

Add LICENSE information
Add missing dependencies (per stage-qa)
Change download location per Mono's Gtk# website.

Test Plan

a) mini exp-run [9.3-i386, 11.0-i386, ports listed above] (done)
b) exp-run [PR213796] (done)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dbn updated this revision to Diff 21688.Oct 26 2016, 5:14 AM

dbn retitled this revision from to lang/mono: update to 4.6.1.5 (and update related ports).

dbn updated this object.

dbn edited the test plan for this revision. (Show Details)

dbn added a reviewer: mat.

dbn set the repository for this revision to rP FreeBSD ports repository.

dbn added a subscriber: mat.

Herald added a reviewer: portmgr. · View Herald TranscriptOct 26 2016, 5:14 AM

I don't really understand why you have to extract the nuget packages files in a separate target and can't use the do-extract one.

Mk/Uses/mono.mk
33–35	I would write this as: if !empty(mono_ARGS:Nnuget) IGNORE= USES=mono can only take :nuget as an argument .endif and use: if ${mono_ARGS:Mnuget} on line 55.

USES=mono: simplify argument handling.

Herald edited edge metadata. · View Herald TranscriptOct 27 2016, 6:17 AM

In D8339#173787, @mat wrote:

I don't really understand why you have to extract the nuget packages files in a separate target and can't use the do-extract one.

Unfortunately the nuget packages don't come in a nice format:

# tar -tf microsoft.fsharp.core.netcore.1.0.0-alpha-160629.nupkg 
_rels/.rels
Microsoft.FSharp.Core.netcore.nuspec
lib/netstandard1.6/FSharp.Core.dll
lib/netstandard1.6/FSharp.Core.sigdata
lib/netstandard1.6/FSharp.Core.optdata
lib/netstandard1.6/FSharp.Core.runtimeconfig.json
content/any/netstandard1.6/FSharp.Core.sigdata
content/any/netstandard1.6/FSharp.Core.optdata
runtimes/any/native/FSharp.Core.sigdata
runtimes/any/native/FSharp.Core.optdata
[Content_Types].xml
package/services/metadata/core-properties/de94b2d5a0f14663a56b03f386620367.psmdcp

Given that the nuget packages need to end up in their own subdirectories, using do-extract makes it somewhat harder.

Although the obviously common files (i.e. '[Content_Types].xml') are excluded from the extraction, there still exists the possibility that two nuget packages have overlapping files. For this reason I think it is impossible to use do-extract.

USES=mono: improve error message on extra arguments.

Herald edited edge metadata. · View Herald TranscriptOct 29 2016, 5:31 AM

Closed by commit rP424974: lang/mono: update to 4.6.1.5. (authored by dbn). · Explain WhyOct 31 2016, 6:58 AM

This revision was automatically updated to reflect the committed changes.

jbeich added a subscriber: jbeich.Nov 1 2016, 9:22 PM

jbeich added inline comments.

head/Mk/Uses/mono.mk
75 ↗	(On Diff #21824)	Why not use `:N` e.g., `${_DISTFILES:N*.nupkg}` ?
78 ↗	(On Diff #21824)	This is too late if a consumer wants to move files around in `post-extract` e.g., rP424981.

dbn added inline comments.Nov 19 2016, 5:27 AM

head/Mk/Uses/mono.mk
75 ↗	(On Diff #21824)	This change then prohibits the port from specifying a file with a .nupkg extension in its DISTFILES. I'll add some documentation to mention this explicitly.
78 ↗	(On Diff #21824)	If I understand the post-extract code wouldn't it be better for the port to define: `NUGET_PACKAGEDIR=${WRKSRC}/thirdparty/download` Either way I'll fix this.