Differential D8060

Add a warning for people who set foo_DEFAULT in their make.conf or environment.
ClosedPublic
Actions

Authored by mat on Sep 28 2016, 2:03 PM.

Details

Reviewers

None

Group Reviewers

portmgr

Commits

rP424571: Add a warning for people who set foo_DEFAULT in their make.conf or environment.

Summary

People are misusing everything, and of course, it breaks. Try to leverage that.

About half a dozen PHP ports set PHP_DEFAULT for a good reason, so something may need to happen in those.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mat updated this revision to Diff 20770.Sep 28 2016, 2:03 PM

mat retitled this revision from to Add a warning for people who set foo_DEFAULT in their make.conf or environment..

mat updated this object.

mat edited the test plan for this revision. (Show Details)

mat added a reviewer: portmgr.

Herald edited edge metadata. · View Herald TranscriptSep 28 2016, 2:03 PM

question: how are you going to implement the "removal" ?

i.e. if SSL_DEFAULT=libressl is set in /etc/make.conf, are you going to force an error if SSL_DEFAULT is defined before it should be?

In D8060#166740, @marino wrote:

question: how are you going to implement the "removal" ?

i.e. if SSL_DEFAULT=libressl is set in /etc/make.conf, are you going to force an error if SSL_DEFAULT is defined before it should be?

I don't know, it is possible, yes, or I will just .undef it and ignore it.

If you intend to ".undef" if, you need to specify that action exactly in the warning message.

Or perhaps emit a notice that the definition was undefined/ignored if it exists too early.

I think the date is a bit long for something that probably isn't that common, and I would almost rather go ahead and make it an error now.

In D8060#166846, @swills wrote:

I think the date is a bit long for something that probably isn't that common, and I would almost rather go ahead and make it an error now.

I started with 2016-12-31 and wondered if it was not too close by, also, I need to figure out how to handle the PHP ports.

Closed by commit rP424571: Add a warning for people who set foo_DEFAULT in their make.conf or environment. (authored by mat). · Explain WhyOct 24 2016, 2:53 PM

This revision was automatically updated to reflect the committed changes.