Page MenuHomeFreeBSD
Differential D8217

Add missing ThunderX release notes
ClosedPublic
Actions

Authored by emaste on Oct 11 2016, 1:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 5:34 AM
Unknown Object (File)
Fri, Mar 28, 10:34 PM
Unknown Object (File)
Sat, Mar 22, 1:45 AM
Unknown Object (File)
Feb 26 2025, 2:05 AM
Unknown Object (File)
Feb 24 2025, 12:28 PM
Unknown Object (File)
Feb 14 2025, 10:18 PM
Unknown Object (File)
Feb 9 2025, 6:36 AM
Unknown Object (File)
Jan 26 2025, 12:33 AM
View All 81 Files
Subscribers
None

Details

Reviewers
bjk
gjb
Commits
rS307061: Add missing ThunderX release notes

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 21249.Oct 11 2016, 1:40 PM
emaste retitled this revision from to Add missing ThunderX release notes.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: gjb, bjk.
gjb added inline comments.Oct 11 2016, 4:45 PM
errata/article.xml
176 ↗(On Diff #21249)

s:&os;/arm64:&os/&arch.arm64;:

179 ↗(On Diff #21249)

Remove empty line.

195 ↗(On Diff #21249)

Remove empty line.

197 ↗(On Diff #21249)

Remove empty line.

emaste updated this revision to Diff 21255.Oct 11 2016, 4:57 PM

style

emaste updated this revision to Diff 21257.Oct 11 2016, 5:08 PM

igor

gjb accepted this revision.Oct 11 2016, 5:11 PM
gjb edited edge metadata.
This revision is now accepted and ready to land.Oct 11 2016, 5:11 PM
Closed by commit rS307061: Add missing ThunderX release notes (authored by emaste). · Explain WhyOct 11 2016, 5:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
en_US.ISO8859-1/
errata/
23 lines
share/
xml/
2 lines

Diff 21255

View Options

doc/en_US.ISO8859-1/errata/article.xml

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
static void add_compunit(enum e_cut, char *); static void add_compunit(enum e_cut, char *);
static void add_file(char *); static void add_file(char *);
static void usage(void); static void usage(void);
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
int c, fflag; int c, fflag, fflagstdin;
char *temp_arg; char *temp_arg;
(void) setlocale(LC_ALL, ""); (void) setlocale(LC_ALL, "");
fflag = 0; fflag = 0;
fflagstdin = 0;
inplace = NULL; inplace = NULL;
while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1) while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1)
switch (c) { switch (c) {
case 'r': /* Gnu sed compat */ case 'r': /* Gnu sed compat */
case 'E': case 'E':
rflags = REG_EXTENDED; rflags = REG_EXTENDED;
break; break;
Show All 9 Lines case 'e':
if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL) if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL)
err(1, "malloc"); err(1, "malloc");
strcpy(temp_arg, optarg); strcpy(temp_arg, optarg);
strcat(temp_arg, "\n"); strcat(temp_arg, "\n");
add_compunit(CU_STRING, temp_arg); add_compunit(CU_STRING, temp_arg);
break; break;
case 'f': case 'f':
fflag = 1; fflag = 1;
if (strcmp(optarg, "-") == 0)
fflagstdin = 1;
add_compunit(CU_FILE, optarg); add_compunit(CU_FILE, optarg);
break; break;
case 'i': case 'i':
inplace = optarg; inplace = optarg;
ispan = 0; /* don't span across input files */ ispan = 0; /* don't span across input files */
break; break;
case 'l': case 'l':
if(setvbuf(stdout, NULL, _IOLBF, 0) != 0) if(setvbuf(stdout, NULL, _IOLBF, 0) != 0)
Show All 20 Linesmain(int argc, char *argv[])
} }
compile(); compile();
/* Continue with first and start second usage */ /* Continue with first and start second usage */
if (*argv) if (*argv)
for (; *argv; argv++) for (; *argv; argv++)
add_file(*argv); add_file(*argv);
else if (fflagstdin)
0mpAuthorUnsubmitted
Done
Inline Actions

There has to be at least one input file specified.

0mp: There has to be at least one input file specified.
exit(rval);
else else
add_file(NULL); add_file(NULL);
process(); process();
cfclose(prog, NULL); cfclose(prog, NULL);
if (fclose(stdout)) if (fclose(stdout))
err(1, "stdout"); err(1, "stdout");
exit(rval); exit(rval);
} }
Show All 27 Lines case ST_EOF:
if (script == NULL) { if (script == NULL) {
if (more != NULL) if (more != NULL)
*more = 0; *more = 0;
return (NULL); return (NULL);
} }
linenum = 0; linenum = 0;
switch (script->type) { switch (script->type) {
case CU_FILE: case CU_FILE:
if (strcmp(script->s, "-") == 0) {
if ((f = fdopen(0, "r")) == NULL)
0mpAuthorUnsubmitted
Done
Inline Actions

I am not sure if it makes any difference if I try to avoid depending on the presence of /dev/stdin by using the 0th descriptor here instead.

0mp: I am not sure if it makes any difference if I try to avoid depending on the presence of…
err(1, "%s", "stdin");
tobikUnsubmitted
Done
Inline Actions

Can this not just be f = stdin?

tobik: Can this not just be `f = stdin`?
0mpAuthorUnsubmitted
Done
Inline Actions

Good catch! The tests are still passing.

0mp: Good catch! The tests are still passing.
fname = "stdin";
0mpAuthorUnsubmitted
Done
Inline Actions

Is stdin name here alright? Perhaps it could be changed to -?

0mp: Is `stdin` name here alright? Perhaps it could be changed to `-`?
} else {
if ((f = fopen(script->s, "r")) == NULL) if ((f = fopen(script->s, "r")) == NULL)
err(1, "%s", script->s); err(1, "%s", script->s);
fname = script->s; fname = script->s;
}
state = ST_FILE; state = ST_FILE;
goto again; goto again;
case CU_STRING: case CU_STRING:
if (((size_t)snprintf(string_ident, if (((size_t)snprintf(string_ident,
sizeof(string_ident), "\"%s\"", script->s)) >= sizeof(string_ident), "\"%s\"", script->s)) >=
sizeof(string_ident) - 1) sizeof(string_ident) - 1)
(void)strcpy(string_ident + (void)strcpy(string_ident +
sizeof(string_ident) - 6, " ...\""); sizeof(string_ident) - 6, " ...\"");
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines
View Options

doc/share/xml/release.ent

Show First 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
static void add_compunit(enum e_cut, char *); static void add_compunit(enum e_cut, char *);
static void add_file(char *); static void add_file(char *);
static void usage(void); static void usage(void);
int int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
int c, fflag; int c, fflag, fflagstdin;
char *temp_arg; char *temp_arg;
(void) setlocale(LC_ALL, ""); (void) setlocale(LC_ALL, "");
fflag = 0; fflag = 0;
fflagstdin = 0;
inplace = NULL; inplace = NULL;
while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1) while ((c = getopt(argc, argv, "EI:ae:f:i:lnru")) != -1)
switch (c) { switch (c) {
case 'r': /* Gnu sed compat */ case 'r': /* Gnu sed compat */
case 'E': case 'E':
rflags = REG_EXTENDED; rflags = REG_EXTENDED;
break; break;
Show All 9 Lines case 'e':
if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL) if ((temp_arg = malloc(strlen(optarg) + 2)) == NULL)
err(1, "malloc"); err(1, "malloc");
strcpy(temp_arg, optarg); strcpy(temp_arg, optarg);
strcat(temp_arg, "\n"); strcat(temp_arg, "\n");
add_compunit(CU_STRING, temp_arg); add_compunit(CU_STRING, temp_arg);
break; break;
case 'f': case 'f':
fflag = 1; fflag = 1;
if (strcmp(optarg, "-") == 0)
fflagstdin = 1;
add_compunit(CU_FILE, optarg); add_compunit(CU_FILE, optarg);
break; break;
case 'i': case 'i':
inplace = optarg; inplace = optarg;
ispan = 0; /* don't span across input files */ ispan = 0; /* don't span across input files */
break; break;
case 'l': case 'l':
if(setvbuf(stdout, NULL, _IOLBF, 0) != 0) if(setvbuf(stdout, NULL, _IOLBF, 0) != 0)
Show All 20 Linesmain(int argc, char *argv[])
} }
compile(); compile();
/* Continue with first and start second usage */ /* Continue with first and start second usage */
if (*argv) if (*argv)
for (; *argv; argv++) for (; *argv; argv++)
add_file(*argv); add_file(*argv);
else if (fflagstdin)
0mpAuthorUnsubmitted
Done
Inline Actions

There has to be at least one input file specified.

0mp: There has to be at least one input file specified.
exit(rval);
else else
add_file(NULL); add_file(NULL);
process(); process();
cfclose(prog, NULL); cfclose(prog, NULL);
if (fclose(stdout)) if (fclose(stdout))
err(1, "stdout"); err(1, "stdout");
exit(rval); exit(rval);
} }
Show All 27 Lines case ST_EOF:
if (script == NULL) { if (script == NULL) {
if (more != NULL) if (more != NULL)
*more = 0; *more = 0;
return (NULL); return (NULL);
} }
linenum = 0; linenum = 0;
switch (script->type) { switch (script->type) {
case CU_FILE: case CU_FILE:
if (strcmp(script->s, "-") == 0) {
if ((f = fdopen(0, "r")) == NULL)
0mpAuthorUnsubmitted
Done
Inline Actions

I am not sure if it makes any difference if I try to avoid depending on the presence of /dev/stdin by using the 0th descriptor here instead.

0mp: I am not sure if it makes any difference if I try to avoid depending on the presence of…
err(1, "%s", "stdin");
tobikUnsubmitted
Done
Inline Actions

Can this not just be f = stdin?

tobik: Can this not just be `f = stdin`?
0mpAuthorUnsubmitted
Done
Inline Actions

Good catch! The tests are still passing.

0mp: Good catch! The tests are still passing.
fname = "stdin";
0mpAuthorUnsubmitted
Done
Inline Actions

Is stdin name here alright? Perhaps it could be changed to -?

0mp: Is `stdin` name here alright? Perhaps it could be changed to `-`?
} else {
if ((f = fopen(script->s, "r")) == NULL) if ((f = fopen(script->s, "r")) == NULL)
err(1, "%s", script->s); err(1, "%s", script->s);
fname = script->s; fname = script->s;
}
state = ST_FILE; state = ST_FILE;
goto again; goto again;
case CU_STRING: case CU_STRING:
if (((size_t)snprintf(string_ident, if (((size_t)snprintf(string_ident,
sizeof(string_ident), "\"%s\"", script->s)) >= sizeof(string_ident), "\"%s\"", script->s)) >=
sizeof(string_ident) - 1) sizeof(string_ident) - 1)
(void)strcpy(string_ident + (void)strcpy(string_ident +
sizeof(string_ident) - 6, " ...\""); sizeof(string_ident) - 6, " ...\"");
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines