Page MenuHomeFreeBSD

skip geom_uzip test on big-endian systems
ClosedPublic

Authored by br on Sep 29 2016, 1:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 5 2024, 3:43 PM
Unknown Object (File)
Oct 20 2024, 5:10 PM
Unknown Object (File)
Oct 18 2024, 7:16 PM
Unknown Object (File)
Oct 18 2024, 11:51 AM
Unknown Object (File)
Oct 18 2024, 6:45 AM
Unknown Object (File)
Oct 11 2024, 9:53 PM
Unknown Object (File)
Oct 3 2024, 10:58 PM
Unknown Object (File)
Oct 2 2024, 7:24 PM
Subscribers

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br retitled this revision from to skip geom_uzip test on big-endian systems.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added a reviewer: ngie.

alternatively we can add pre-generated big-endian uzip image, like this.

jmmv requested changes to this revision.Oct 10 2016, 7:34 PM
jmmv added a reviewer: jmmv.
jmmv added a subscriber: jmmv.
jmmv added inline comments.
tests/sys/geom/class/uzip/1_test.sh
9

$endian -eq 0 means nothing and the line above is pretty much magic. Please find a better name for this variable and consider extending the comment to explain what you are doing in some detail.

Also, test the three possible cases for the variable value: 0, whatever the "else" branch currently expects, and the case where the command above produces a failure.

10

1_eb is cryptic... and it's not orthogonal with the other file name. 1_big_endian... would be better, and then rename the other file to 1_little_endian.

This revision now requires changes to proceed.Oct 10 2016, 7:34 PM
ngie requested changes to this revision.Oct 10 2016, 7:57 PM
ngie edited edge metadata.
ngie added inline comments.
tests/sys/geom/class/uzip/1_test.sh
9

Agreed... This variable should likely be called "big_endian" and should be either "true" or "false", then tested like:

if $big_endian; then
    # Use big endian file.
else
    # Use little endian file.
fi

It seems like this should be a general purpose program usable for all tests.

10

+1

br edited edge metadata.

change filenames, parameter names, etc

br edited edge metadata.

add context

ngie edited edge metadata.

Looks good minus my recommendation about using "=" instead of "==" in conditionals.

tests/sys/geom/class/uzip/1_test.sh
9

Please use "=" instead of "==". It doesn't matter for FreeBSD 10+, but it does matter for code cleanliness (just in case someone tried to run these tests on FreeBSD 9 and below), and is POSIX conformant.

br edited edge metadata.

use = instead of ==

br edited edge metadata.

forgot file

This revision was automatically updated to reflect the committed changes.