Page MenuHomeFreeBSD
Differential D8148

shells/fish 2.3.1: backspace is broken with UTF-8 terminals
AbandonedPublic
Actions

Authored by asomers on Oct 4 2016, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 17, 8:54 PM
Unknown Object (File)
Fri, Apr 10, 4:33 AM
Unknown Object (File)
Thu, Apr 9, 11:30 PM
Unknown Object (File)
Mon, Apr 6, 4:26 PM
Unknown Object (File)
Sun, Apr 5, 7:14 AM
Unknown Object (File)
Mar 8 2026, 3:12 PM
Unknown Object (File)
Mar 4 2026, 6:39 PM
Unknown Object (File)
Mar 4 2026, 1:29 AM
View All 86 Files
Subscribers
mat

Details

Reviewers
pi
vlad-fbsd_acheronmedia.com
Summary

Backspace, delete, arrow keys, and more are broken in fish-2.3.1 when LC_ALL
is set to a UTF-8 locale. Fix the bug by backporting upstream's fix to
2.3.1

https://github.com/fish-shell/fish-shell/commit/92dd6de73ccdb37facc43f768653e11941448a6b

PR: 212955

Test Plan

Invoke the shell with each of LC_ALL=C and LC_ALL=en_US.UTF-8 and manually
try backspace, delete, and arrow keys

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 5437
Build 5644: arc lint + arc unit

Event Timeline

asomers updated this revision to Diff 21028.Oct 4 2016, 3:12 PM
asomers retitled this revision from to shells/fish 2.3.1: backspace is broken with UTF-8 terminals.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added reviewers: pi, vlad-fbsd_acheronmedia.com.
Herald added a subscriber: mat. · View Herald TranscriptOct 4 2016, 3:12 PM
asomers abandoned this revision.Jan 7 2017, 7:00 PM

Obsoleted by r430488

Revision Contents
Changeset List

PathSize
shells/
fish/
2 lines
files/
43 lines
48 lines
34 lines
95 lines

Diff 21028

View Options

shells/fish/Makefile

Loading...
View Options

shells/fish/files/patch-src_common.h

Loading...
View Options

shells/fish/files/patch-src_common.cpp

Loading...
View Options

shells/fish/files/patch-src_wutil.h

Loading...
View Options

shells/fish/files/patch-src_wutil.cpp

Loading...