Details
- Reviewers
ngie jmmv - Group Reviewers
tests - Commits
- rS307625: Add big-endian uzip file system and choose right file system
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| tests/sys/geom/class/uzip/1_test.sh | ||
|---|---|---|
| 9 | $endian -eq 0 means nothing and the line above is pretty much magic. Please find a better name for this variable and consider extending the comment to explain what you are doing in some detail. Also, test the three possible cases for the variable value: 0, whatever the "else" branch currently expects, and the case where the command above produces a failure. | |
| 10 | 1_eb is cryptic... and it's not orthogonal with the other file name. 1_big_endian... would be better, and then rename the other file to 1_little_endian. | |
| tests/sys/geom/class/uzip/1_test.sh | ||
|---|---|---|
| 9 | Agreed... This variable should likely be called "big_endian" and should be either "true" or "false", then tested like: if $big_endian; then
# Use big endian file.
else
# Use little endian file.
fiIt seems like this should be a general purpose program usable for all tests. | |
| 10 | +1 | |
Looks good minus my recommendation about using "=" instead of "==" in conditionals.
| tests/sys/geom/class/uzip/1_test.sh | ||
|---|---|---|
| 9 | Please use "=" instead of "==". It doesn't matter for FreeBSD 10+, but it does matter for code cleanliness (just in case someone tried to run these tests on FreeBSD 9 and below), and is POSIX conformant. | |