bash 4.4 has been released and given the importance of the port I would like to get some feedback.
Changelog from upstream:
http://tiswww.case.edu/php/chet/bash/NEWS
Details
Details
- Reviewers
bapt - Commits
- rP423003: Update to 4.4
- poudriere testport ... shells/bash
- poudriere testport ... shells/bash-static
- portlint -A
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| Makefile | ||
|---|---|---|
| 72 ↗ | (On Diff #20844) | USES=pathfix should do that for you, no? |
| Makefile | ||
|---|---|---|
| 72 ↗ | (On Diff #20844) | Unfortunately it doesn't catch the following lines in ${WRKSRC}/Makefile.in @${SHELL} $(SUPPORT_SRC)mkinstalldirs $(DESTDIR)$(libdir)/pkgconfig
$(INSTALL_DATA) $(SDIR)/bash.pc $(DESTDIR)$(libdir)/pkgconfig/bash.pc
-( $(RM) $(DESTDIR)$(libdir)/pkgconfig/bash.pc ) |
| Makefile | ||
|---|---|---|
| 72 ↗ | (On Diff #20844) | I take this back. It does. I'll fix this. |
| pkg-plist | ||
|---|---|---|
| 62 ↗ | (On Diff #20844) | Good catch. |
Comment Actions
In the future, could you upload the diff with arcanist, or at least, generate the diff so that it has context, like arcanist does, with svn diff --diff-cmd=diff -x -U9999. (Or if using git, git diff -U9999)
Comment Actions
Definitely. I realized when I wanted to send an update with:
arc diff --update ...
There is no way to fix this afterwards, right?