Page MenuHomeFreeBSD

Update bash to 4.4
ClosedPublic

Authored by ehaupt on Sep 29 2016, 11:36 PM.

Details

Reviewers
bapt
Commits
rP423003: Update to 4.4
Summary

bash 4.4 has been released and given the importance of the port I would like to get some feedback.

Changelog from upstream:

http://tiswww.case.edu/php/chet/bash/NEWS
Test Plan
  • poudriere testport ... shells/bash
  • poudriere testport ... shells/bash-static
  • portlint -A

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ehaupt retitled this revision from to Update bash to 4.4.
ehaupt updated this object.
ehaupt edited the test plan for this revision. (Show Details)
ehaupt set the repository for this revision to rP FreeBSD ports repository.

Fixed hard coded PREFIX path during patch re-creation.

bapt added inline comments.
Makefile
72 ↗(On Diff #20844)

USES=pathfix should do that for you, no?

Makefile
72 ↗(On Diff #20844)

Unfortunately it doesn't catch the following lines in ${WRKSRC}/Makefile.in

@${SHELL} $(SUPPORT_SRC)mkinstalldirs $(DESTDIR)$(libdir)/pkgconfig
$(INSTALL_DATA) $(SDIR)/bash.pc $(DESTDIR)$(libdir)/pkgconfig/bash.pc
-( $(RM) $(DESTDIR)$(libdir)/pkgconfig/bash.pc )
Makefile
72 ↗(On Diff #20844)

It should:

s|[(]libdir[)]/pkgconfig|(prefix)/libdata/pkgconfig|g ; \
pkg-plist
62 ↗(On Diff #20844)

This should go.

Makefile
72 ↗(On Diff #20844)

I take this back. It does. I'll fix this.

pkg-plist
62 ↗(On Diff #20844)

Good catch.

  • Use pathfix instead of manual patch
  • Remove stray info directory from pkg-plist
bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Sep 30 2016, 8:29 AM

In the future, could you upload the diff with arcanist, or at least, generate the diff so that it has context, like arcanist does, with svn diff --diff-cmd=diff -x -U9999. (Or if using git, git diff -U9999)

In D8085#167391, @mat wrote:

In the future, could you upload the diff with arcanist, or at least, generate the diff so that it has context, like arcanist does, with svn diff --diff-cmd=diff -x -U9999. (Or if using git, git diff -U9999)

Definitely. I realized when I wanted to send an update with:

arc diff --update ...

There is no way to fix this afterwards, right?

ehaupt edited edge metadata.

Diff created with: svn diff --diff-cmd=diff -x -U999999

This revision now requires review to proceed.Sep 30 2016, 9:53 AM
bapt edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2016, 2:44 PM
This revision was automatically updated to reflect the committed changes.