Update bash to 4.4

[ehaupt]

Summary

bash 4.4 has been released and given the importance of the port I would like to get some feedback.

Changelog from upstream:

http://tiswww.case.edu/php/chet/bash/NEWS

Test Plan

• poudriere testport ... shells/bash
• poudriere testport ... shells/bash-static
• portlint -A

[ehaupt]

Fixed hard coded PREFIX path during patch re-creation.

[bapt]

Makefile

72 ↗

(On Diff #20844)

USES=pathfix should do that for you, no?

[ehaupt]

Makefile

72 ↗

(On Diff #20844)

Unfortunately it doesn't catch the following lines in ${WRKSRC}/Makefile.in

@${SHELL} $(SUPPORT_SRC)mkinstalldirs $(DESTDIR)$(libdir)/pkgconfig
$(INSTALL_DATA) $(SDIR)/bash.pc $(DESTDIR)$(libdir)/pkgconfig/bash.pc
-( $(RM) $(DESTDIR)$(libdir)/pkgconfig/bash.pc )

[mat]

Makefile

72 ↗

(On Diff #20844)

It should:

s|[(]libdir[)]/pkgconfig|(prefix)/libdata/pkgconfig|g ; \

pkg-plist

62 ↗

(On Diff #20844)

This should go.

[ehaupt]

Makefile

72 ↗

(On Diff #20844)

I take this back. It does. I'll fix this.

[ehaupt]

pkg-plist

62 ↗

(On Diff #20844)

Good catch.

[ehaupt]

• Use pathfix instead of manual patch
• Remove stray info directory from pkg-plist

[mat]

In the future, could you upload the diff with arcanist, or at least, generate the diff so that it has context, like arcanist does, with svn diff --diff-cmd=diff -x -U9999. (Or if using git, git diff -U9999)

[ehaupt]

In D8085#167391, @mat wrote:

In the future, could you upload the diff with arcanist, or at least, generate the diff so that it has context, like arcanist does, with svn diff --diff-cmd=diff -x -U9999. (Or if using git, git diff -U9999)

Definitely. I realized when I wanted to send an update with:

arc diff --update ...

There is no way to fix this afterwards, right?

[ehaupt]

Diff created with: svn diff --diff-cmd=diff -x -U999999