Page MenuHomeFreeBSD

[iwm] Remove unused field from iwm_rx_data. Use uint32_t instead of enum type.
ClosedPublic

Authored by ivadasz on Sep 18 2016, 9:23 AM.
Tags
None
Referenced Files
F159149686: D7930.id20500.diff
Wed, Jun 10, 4:08 PM
Unknown Object (File)
Tue, Jun 9, 11:37 AM
Unknown Object (File)
Tue, Jun 9, 1:20 AM
Unknown Object (File)
Sun, Jun 7, 8:52 AM
Unknown Object (File)
Tue, May 26, 11:45 AM
Unknown Object (File)
Thu, May 14, 11:24 AM
Unknown Object (File)
May 6 2026, 10:14 PM
Unknown Object (File)
May 6 2026, 1:16 AM
Subscribers

Details

Summary

The wantresp field in struct iwm_rx_data has never been used for anything,
so we can just delete it.

Apparently struct iwm_sf_cfg_cmd was compiled correctly (using a 32bit
value to represent the enum), but it still seems like a very bad idea to use
an enum type in a __packed struct.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivadasz retitled this revision from to [iwm] Remove unused field from iwm_rx_data. Use uint32_t instead of enum type..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
adrian edited edge metadata.
This revision is now accepted and ready to land.Sep 19 2016, 9:36 PM
This revision was automatically updated to reflect the committed changes.