Page MenuHomeFreeBSD

[iwm] Remove unused field from iwm_rx_data. Use uint32_t instead of enum type.
ClosedPublic

Authored by ivadasz on Sep 18 2016, 9:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 12:46 AM
Unknown Object (File)
Fri, Nov 21, 12:45 AM
Unknown Object (File)
Fri, Nov 21, 12:45 AM
Unknown Object (File)
Fri, Nov 21, 12:41 AM
Unknown Object (File)
Tue, Nov 18, 12:55 AM
Unknown Object (File)
Sat, Nov 15, 8:31 PM
Unknown Object (File)
Nov 7 2025, 10:23 PM
Unknown Object (File)
Nov 4 2025, 2:25 PM
Subscribers

Details

Summary

The wantresp field in struct iwm_rx_data has never been used for anything,
so we can just delete it.

Apparently struct iwm_sf_cfg_cmd was compiled correctly (using a 32bit
value to represent the enum), but it still seems like a very bad idea to use
an enum type in a __packed struct.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5194
Build 5327: arc lint + arc unit

Event Timeline

ivadasz retitled this revision from to [iwm] Remove unused field from iwm_rx_data. Use uint32_t instead of enum type..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.
adrian edited edge metadata.
This revision is now accepted and ready to land.Sep 19 2016, 9:36 PM
This revision was automatically updated to reflect the committed changes.