[iwm] Get rid of SYNC_RESP_STRUCT and SYNC_RESP_PTR macros.
ClosedPublic
Actions

Authored by ivadasz on Sep 18 2016, 11:59 AM.

Details

Reviewers

cognet
adrian

Commits

rS308183: [iwm] Get rid of SYNC_RESP_STRUCT and SYNC_RESP_PTR macros.

Summary

SYNC_RESP_STRUCT and SYNC_RESP_PTR originate from the OpenBSD version of
iwm, and they weren't serving any real purpose in the FreeBSD port.

We just do a single bus_dmamap_sync for syncing the complete received frame,
instead of explicitly bus_dmamap_sync-ing subranges of the frame like in
the OpenBSD iwm code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5206
Build 5342: arc lint + arc unit

Event Timeline

ivadasz updated this revision to Diff 20446.Sep 18 2016, 11:59 AM

ivadasz retitled this revision from to [iwm] Get rid of SYNC_RESP_STRUCT and SYNC_RESP_PTR macros..

ivadasz updated this object.

ivadasz added reviewers: adrian, cognet.

Herald added a subscriber: imp. · View Herald TranscriptSep 18 2016, 11:59 AM

hm, so we're already correctly sync'ing the payload as well as the descriptor?

In (line numbers from right side of the diff) line 5034 the descriptors are synced, and in line 5049 the payload is synced. All the SYNC_RESP_STRUCT macro usages were just repeating the syncing of the payload.

adrian accepted this revision.Nov 1 2016, 10:24 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Nov 1 2016, 10:24 PM

Closed by commit rS308183: [iwm] Get rid of SYNC_RESP_STRUCT and SYNC_RESP_PTR macros. (authored by ivadasz). · Explain WhyNov 1 2016, 10:38 PM

This revision was automatically updated to reflect the committed changes.