Page MenuHomeFreeBSD

[iwm] Get rid of SYNC_RESP_STRUCT and SYNC_RESP_PTR macros.
ClosedPublic

Authored by ivadasz on Sep 18 2016, 11:59 AM.
Tags
None
Referenced Files
F106099458: D7939.diff
Wed, Dec 25, 9:39 AM
Unknown Object (File)
Nov 21 2024, 9:34 PM
Unknown Object (File)
Nov 5 2024, 12:20 PM
Unknown Object (File)
Nov 5 2024, 11:54 AM
Unknown Object (File)
Oct 26 2024, 1:53 AM
Unknown Object (File)
Sep 16 2024, 4:11 PM
Unknown Object (File)
Sep 15 2024, 1:14 PM
Unknown Object (File)
Sep 12 2024, 2:41 PM
Subscribers

Details

Summary

SYNC_RESP_STRUCT and SYNC_RESP_PTR originate from the OpenBSD version of
iwm, and they weren't serving any real purpose in the FreeBSD port.

We just do a single bus_dmamap_sync for syncing the complete received frame,
instead of explicitly bus_dmamap_sync-ing subranges of the frame like in
the OpenBSD iwm code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5206
Build 5342: arc lint + arc unit

Event Timeline

ivadasz retitled this revision from to [iwm] Get rid of SYNC_RESP_STRUCT and SYNC_RESP_PTR macros..
ivadasz updated this object.
ivadasz added reviewers: adrian, cognet.

hm, so we're already correctly sync'ing the payload as well as the descriptor?

In (line numbers from right side of the diff) line 5034 the descriptors are synced, and in line 5049 the payload is synced. All the SYNC_RESP_STRUCT macro usages were just repeating the syncing of the payload.

adrian edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 10:24 PM
This revision was automatically updated to reflect the committed changes.