Page MenuHomeFreeBSD
Differential D7903

Indicate that this is a locally administered MAC address.
ClosedPublic
Actions

Authored by araujo on Sep 16 2016, 4:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 2:45 PM
Unknown Object (File)
Thu, Oct 31, 1:11 PM
Unknown Object (File)
Oct 7 2024, 7:56 AM
Unknown Object (File)
Sep 20 2024, 6:16 PM
Unknown Object (File)
Sep 9 2024, 6:12 AM
Unknown Object (File)
Sep 8 2024, 6:25 AM
Unknown Object (File)
Aug 31 2024, 1:14 PM
Unknown Object (File)
Aug 31 2024, 1:14 PM
View All 56 Files
Subscribers
imp

Details

Reviewers
pi
jhb
• lidl
Commits
rS331729: MFC r305860, r306371
rS306371: Indicate that this is a locally administered MAC address.
Summary

I forgot to address lidl@ suggestion on review D7615.

lidl@
"""
I think this should really be clearing the lowest bit of the first octet to clean the multicast bit, and then setting on the second lowest bit of the first octet, to indicate that this is a locally administered MAC address.
"""

Diff Detail

Event Timeline

araujo updated this revision to Diff 20379.Sep 16 2016, 4:59 AM
araujo retitled this revision from to Indicate that this is a locally administered MAC address..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added reviewers: • lidl, jhb, pi.
Herald added a subscriber: imp. · View Herald TranscriptSep 16 2016, 4:59 AM
• lidl accepted this revision.Sep 16 2016, 5:08 AM
• lidl edited edge metadata.

With or without the comment change, the code change looks OK to me.

sbin/ifconfig/af_link.c
99

Probably should change this comment so it reads:

"Non-multicast and claim it is locally administered."

This revision is now accepted and ready to land.Sep 16 2016, 5:08 AM
araujo updated this revision to Diff 20380.Sep 16 2016, 5:18 AM
araujo edited edge metadata.

Rephrase the comment to reflect the locally administered part.

Thanks lidl@

This revision now requires review to proceed.Sep 16 2016, 5:18 AM
• lidl accepted this revision.Sep 16 2016, 5:33 AM
• lidl edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2016, 5:33 AM
araujo added a comment.Sep 21 2016, 8:49 PM

@lidl I'm in a business trip, if you don't mind, can you commit it?

Best,

Closed by commit rS306371: Indicate that this is a locally administered MAC address. (authored by araujo). · Explain WhySep 27 2016, 5:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
3 lines

Diff 20380

View Options

sbin/ifconfig/af_link.c

Loading...